Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: components/display_compositor/yuv_readback_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/display_compositor/yuv_readback_unittest.cc
diff --git a/components/display_compositor/yuv_readback_unittest.cc b/components/display_compositor/yuv_readback_unittest.cc
index fe595e3364a996f698bca51a3454823b27149c29..27a3f9fc677682a03c96d365b09acb3114a96807 100644
--- a/components/display_compositor/yuv_readback_unittest.cc
+++ b/components/display_compositor/yuv_readback_unittest.cc
@@ -98,21 +98,21 @@ class YUVReadbackTest : public testing::Test {
std::string error_msg;
std::unique_ptr<base::Value> trace_data =
base::JSONReader::ReadAndReturnError(json_data, 0, NULL, &error_msg);
- CHECK(trace_data) << "JSON parsing failed (" << error_msg
- << ") JSON data:" << std::endl
- << json_data;
+ ASSERT_TRUE(trace_data) << "JSON parsing failed (" << error_msg
+ << ") JSON data:" << std::endl
+ << json_data;
base::ListValue* list;
- CHECK(trace_data->GetAsList(&list));
+ ASSERT_TRUE(trace_data->GetAsList(&list));
for (size_t i = 0; i < list->GetSize(); i++) {
base::Value* item = NULL;
if (list->Get(i, &item)) {
base::DictionaryValue* dict;
- CHECK(item->GetAsDictionary(&dict));
+ ASSERT_TRUE(item->GetAsDictionary(&dict));
std::string name;
- CHECK(dict->GetString("name", &name));
+ ASSERT_TRUE(dict->GetString("name", &name));
std::string trace_type;
- CHECK(dict->GetString("ph", &trace_type));
+ ASSERT_TRUE(dict->GetString("ph", &trace_type));
// Count all except END traces, as they come in BEGIN/END pairs.
if (trace_type != "E" && trace_type != "e")
(*event_counts)[name]++;

Powered by Google App Engine
This is Rietveld 408576698