Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/cronet/url_request_context_config.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/cronet/ios/Cronet.mm ('k') | components/display_compositor/yuv_readback_unittest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/url_request_context_config.cc
diff --git a/components/cronet/url_request_context_config.cc b/components/cronet/url_request_context_config.cc
index 78497f77d576d6776c4cbdebed70437c8fa14528..ef09b411a6a580d92f3abb7c7edf3d825340e300 100644
--- a/components/cronet/url_request_context_config.cc
+++ b/components/cronet/url_request_context_config.cc
@@ -249,8 +249,8 @@ void ParseAndSetExperimentalOptions(
if (async_dns_enable || stale_dns_enable || host_resolver_rules_enable) {
if (net_log == nullptr) {
- CHECK(false) << "AsyncDNS, StaleDNS, and HostResolverRules experiments "
- << "require NetLog.";
+ // AsyncDNS, StaleDNS, and HostResolverRules experiments require NetLog.
+ CHECK(false);
}
std::unique_ptr<net::HostResolver> host_resolver;
if (stale_dns_enable) {
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/cronet/ios/Cronet.mm ('k') | components/display_compositor/yuv_readback_unittest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698