chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « chrome/browser/sync/test/integration/sync_test.cc ('k') | chrome/browser/task_manager/task_manager_tester.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

diff --git a/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc b/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

index 705ae8493a161370ef1c29428e8afe1107c44a12..e31184fc77bc4a4c7b53810b50cb38c0568685e7 100644

--- a/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

+++ b/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

@@ -104,8 +104,8 @@ void AddWifiCredentialToProfileChromeOs(

DCHECK(browser_context);

std::unique_ptr<base::DictionaryValue> onc_properties =

credential.ToOncProperties();

- CHECK(onc_properties) << "Failed to generate ONC properties for "

- << credential.ToString();

+ // Failed to generate ONC properties for |credential.ToString()|

+ CHECK(onc_properties);

GetManagedNetworkConfigurationHandler()->CreateConfiguration(

ChromeOsUserHashForBrowserContext(*browser_context), *onc_properties,

::chromeos::network_handler::ServiceResultCallback(),