Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos. h" 5 #include "chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos. h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 policy_network_configs, 97 policy_network_configs,
98 policy_global_config); 98 policy_global_config);
99 } 99 }
100 100
101 void AddWifiCredentialToProfileChromeOs( 101 void AddWifiCredentialToProfileChromeOs(
102 const content::BrowserContext* browser_context, 102 const content::BrowserContext* browser_context,
103 const WifiCredential& credential) { 103 const WifiCredential& credential) {
104 DCHECK(browser_context); 104 DCHECK(browser_context);
105 std::unique_ptr<base::DictionaryValue> onc_properties = 105 std::unique_ptr<base::DictionaryValue> onc_properties =
106 credential.ToOncProperties(); 106 credential.ToOncProperties();
107 CHECK(onc_properties) << "Failed to generate ONC properties for " 107 // Failed to generate ONC properties for |credential.ToString()|
108 << credential.ToString(); 108 CHECK(onc_properties);
109 GetManagedNetworkConfigurationHandler()->CreateConfiguration( 109 GetManagedNetworkConfigurationHandler()->CreateConfiguration(
110 ChromeOsUserHashForBrowserContext(*browser_context), *onc_properties, 110 ChromeOsUserHashForBrowserContext(*browser_context), *onc_properties,
111 ::chromeos::network_handler::ServiceResultCallback(), 111 ::chromeos::network_handler::ServiceResultCallback(),
112 base::Bind(LogCreateConfigurationFailure, 112 base::Bind(LogCreateConfigurationFailure,
113 base::StringPrintf("Failed to add credential %s", 113 base::StringPrintf("Failed to add credential %s",
114 credential.ToString().c_str()))); 114 credential.ToString().c_str())));
115 base::RunLoop().RunUntilIdle(); 115 base::RunLoop().RunUntilIdle();
116 } 116 }
117 117
118 WifiCredentialSet GetWifiCredentialsForProfileChromeOs( 118 WifiCredentialSet GetWifiCredentialsForProfileChromeOs(
119 const content::BrowserContext* browser_context) { 119 const content::BrowserContext* browser_context) {
120 DCHECK(browser_context); 120 DCHECK(browser_context);
121 return sync_wifi::GetWifiCredentialsForShillProfile( 121 return sync_wifi::GetWifiCredentialsForShillProfile(
122 GetNetworkStateHandler(), 122 GetNetworkStateHandler(),
123 ShillProfilePathForBrowserContext(*browser_context)); 123 ShillProfilePathForBrowserContext(*browser_context));
124 } 124 }
125 125
126 } // namespace chromeos 126 } // namespace chromeos
127 127
128 } // namespace wifi_credentials_helper 128 } // namespace wifi_credentials_helper
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698