Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2859)

Unified Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc
index 0800d650c235317a0ff1c09cbc2eb4f784a56652..693949da0288fcdcc75083c6a5d2765f80cd183d 100644
--- a/chrome/browser/sync/test/integration/sync_test.cc
+++ b/chrome/browser/sync/test/integration/sync_test.cc
@@ -326,7 +326,8 @@ bool SyncTest::CreateGaiaAccount(const std::string& username,
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::NavigationEntry* entry = contents->GetController().GetVisibleEntry();
- CHECK(entry) << "Could not get a hold on NavigationEntry post URL navigate.";
+ // Could not get a hold on NavigationEntry post URL navigate.
+ CHECK(entry);
DVLOG(1) << "Create Gaia account request return code = "
<< entry->GetHttpStatusCode();
return entry->GetHttpStatusCode() == 200;
@@ -493,8 +494,8 @@ bool SyncTest::SetupClients() {
fake_server_invalidation_services_.resize(num_clients_);
if (create_gaia_account_at_runtime_) {
- CHECK(UsingExternalServers()) <<
- "Cannot create Gaia accounts without external authentication servers";
+ // Cannot create Gaia accounts without external authentication servers
+ CHECK(UsingExternalServers());
if (!CreateGaiaAccount(username_, password_))
LOG(FATAL) << "Could not create Gaia account.";
}

Powered by Google App Engine
This is Rietveld 408576698