Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

This is the first part of a larger migration of some parts of proximity_auth
into cryptauth.

BUG=672263
Committed: https://crrev.com/e7ad389b8dc346d0167af4b836144f1fbc5e2cd8
Cr-Commit-Position: refs/heads/master@{#439587}

[Ryan Hansberry, 2016-12-08 21:36:34]

hansberry@chromium.org changed reviewers:
+ khorimoto@chromium.org, tengs@chromium.org

[Kyle Horimoto, 2016-12-08 21:52:41]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD.gn
File components/cryptauth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD....
components/cryptauth/BUILD.gn:65: allow_circular_includes_from = [
"//components/cryptauth/ble" ]
What is your plan for resolving this and the other circular dependencies?

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
This should have been removed when I made the move originally; can you please
remove it in this CL?

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/bl...
File components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h
(right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/bl...
components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h:52: :
public proximity_auth::Connection,
//components/cryptauth should not depend on //components/proximity_auth. You'll
need to migrate Connection over.

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/fa...
File components/cryptauth/ble/fake_wire_message.h (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/fa...
components/cryptauth/ble/fake_wire_message.h:16: class FakeWireMessage : public
proximity_auth::WireMessage {
Likewise. The dependency is supposed to be from //components/proximity_auth to
//components/cryptauth, not the other way around.

https://codereview.chromium.org/2561203002/diff/1/components/proximity_auth/B...
File components/proximity_auth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/proximity_auth/B...
components/proximity_auth/BUILD.gn:86: "//components/cryptauth/ble",  # TODO
(hansberry): Remove after migration.
This shouldn't need to be the case.

[Ryan Hansberry, 2016-12-09 01:18:14]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> This should have been removed when I made the move originally; can you please
> remove it in this CL?

Unfortunately it seems that cryptauth depends on proximity/logging in some
places. Would you like me to remove that dependency in this CL? (It may be
better to punt it to another CL)

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/bl...
File components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h
(right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/bl...
components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h:52: :
public proximity_auth::Connection,
On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> //components/cryptauth should not depend on //components/proximity_auth.
You'll
> need to migrate Connection over.

Done.

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/fa...
File components/cryptauth/ble/fake_wire_message.h (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/ble/fa...
components/cryptauth/ble/fake_wire_message.h:16: class FakeWireMessage : public
proximity_auth::WireMessage {
On 2016/12/08 21:52:41, Kyle Horimoto wrote:
> Likewise. The dependency is supposed to be from //components/proximity_auth to
> //components/cryptauth, not the other way around.

Of course, this was only intended as a way to iteratively migrate classes over.
I've now removed this incorrect dependency.

https://codereview.chromium.org/2561203002/diff/1/components/proximity_auth/B...
File components/proximity_auth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/proximity_auth/B...
components/proximity_auth/BUILD.gn:86: "//components/cryptauth/ble",  # TODO
(hansberry): Remove after migration.
On 2016/12/08 21:52:41, Kyle Horimoto wrote:
> This shouldn't need to be the case.

Done.

[Kyle Horimoto, 2016-12-09 01:25:09]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD.gn
File components/cryptauth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD....
components/cryptauth/BUILD.gn:65: allow_circular_includes_from = [
"//components/cryptauth/ble" ]
On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> What is your plan for resolving this and the other circular dependencies?

Ping.

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > This should have been removed when I made the move originally; can you
please
> > remove it in this CL?
> 
> Unfortunately it seems that cryptauth depends on proximity/logging in some
> places. Would you like me to remove that dependency in this CL? (It may be
> better to punt it to another CL)

Make this depend on logging instead of the entire package then.

https://codereview.chromium.org/2561203002/diff/20001/components/cryptauth/bl...
File components/cryptauth/ble/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/20001/components/cryptauth/bl...
components/cryptauth/ble/BUILD.gn:29: # "//components/cryptauth",
This is commented out, so let's just remove it.

[Ryan Hansberry, 2016-12-09 02:36:50]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD.gn
File components/cryptauth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD....
components/cryptauth/BUILD.gn:65: allow_circular_includes_from = [
"//components/cryptauth/ble" ]
On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > What is your plan for resolving this and the other circular dependencies?
> 
> Ping.

I see two ways to solve this:

1) Consolidate all of these migrated classes from proximity_auth into a single
subdirectory (called 'connection/' or something like that)

2) Maintain the new cryptauth/ble/ directory, and place the classes it depends
on within root cryptauth/ into a subdirectory, something like
'cryptauth/connection'.

Do you like either of these methods or have another idea?

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > This should have been removed when I made the move originally; can you
> please
> > > remove it in this CL?
> > 
> > Unfortunately it seems that cryptauth depends on proximity/logging in some
> > places. Would you like me to remove that dependency in this CL? (It may be
> > better to punt it to another CL)
> 
> Make this depend on logging instead of the entire package then.

Unfortunately cryptauth also depends on
proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies to
just that and proximity_auth/logging.

https://codereview.chromium.org/2561203002/diff/20001/components/cryptauth/bl...
File components/cryptauth/ble/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/20001/components/cryptauth/bl...
components/cryptauth/ble/BUILD.gn:29: # "//components/cryptauth",
On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> This is commented out, so let's just remove it.

Done.

[Kyle Horimoto, 2016-12-09 18:07:46]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD.gn
File components/cryptauth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD....
components/cryptauth/BUILD.gn:65: allow_circular_includes_from = [
"//components/cryptauth/ble" ]
On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > What is your plan for resolving this and the other circular dependencies?
> > 
> > Ping.
> 
> I see two ways to solve this:
> 
> 1) Consolidate all of these migrated classes from proximity_auth into a single
> subdirectory (called 'connection/' or something like that)
> 
> 2) Maintain the new cryptauth/ble/ directory, and place the classes it depends
> on within root cryptauth/ into a subdirectory, something like
> 'cryptauth/connection'.
> 
> Do you like either of these methods or have another idea?

Cool, those both sound reasonable. No need to do it in this CL, though...it's
already gotten pretty big. Thanks!

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > > This should have been removed when I made the move originally; can you
> > please
> > > > remove it in this CL?
> > > 
> > > Unfortunately it seems that cryptauth depends on proximity/logging in some
> > > places. Would you like me to remove that dependency in this CL? (It may be
> > > better to punt it to another CL)
> > 
> > Make this depend on logging instead of the entire package then.
> 
> Unfortunately cryptauth also depends on
> proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies
to
> just that and proximity_auth/logging.

Can you move that file over to cryptauth as well? Thanks!

[Ryan Hansberry, 2016-12-09 20:11:05]

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD.gn
File components/cryptauth/BUILD.gn (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/BUILD....
components/cryptauth/BUILD.gn:65: allow_circular_includes_from = [
"//components/cryptauth/ble" ]
On 2016/12/09 18:07:46, Kyle Horimoto wrote:
> On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> > On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > > What is your plan for resolving this and the other circular
dependencies?
> > > 
> > > Ping.
> > 
> > I see two ways to solve this:
> > 
> > 1) Consolidate all of these migrated classes from proximity_auth into a
single
> > subdirectory (called 'connection/' or something like that)
> > 
> > 2) Maintain the new cryptauth/ble/ directory, and place the classes it
depends
> > on within root cryptauth/ into a subdirectory, something like
> > 'cryptauth/connection'.
> > 
> > Do you like either of these methods or have another idea?
> 
> Cool, those both sound reasonable. No need to do it in this CL, though...it's
> already gotten pretty big. Thanks!

Great. I'll do that right after this CL.

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS
File components/cryptauth/DEPS (right):

https://codereview.chromium.org/2561203002/diff/1/components/cryptauth/DEPS#n...
components/cryptauth/DEPS:4: "+components/proximity_auth",
On 2016/12/09 18:07:46, Kyle Horimoto wrote:
> On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> > On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > > On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > > > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > > > This should have been removed when I made the move originally; can you
> > > please
> > > > > remove it in this CL?
> > > > 
> > > > Unfortunately it seems that cryptauth depends on proximity/logging in
some
> > > > places. Would you like me to remove that dependency in this CL? (It may
be
> > > > better to punt it to another CL)
> > > 
> > > Make this depend on logging instead of the entire package then.
> > 
> > Unfortunately cryptauth also depends on
> > proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies
> to
> > just that and proximity_auth/logging.
> 
> Can you move that file over to cryptauth as well? Thanks!

Done, and renamed to cryptauth_test_util.

[Kyle Horimoto, 2016-12-09 20:12:08]

lgtm, but don't submit until Tim reviews.

[Tim Song, 2016-12-15 03:34:36]

lgtm

[Ryan Hansberry, 2016-12-15 18:29:08]

The CQ bit was checked by hansberry@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:29:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:34:08]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hansberry, 2016-12-16 01:24:36]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-16 01:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-12-16 01:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:34:35]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hansberry, 2016-12-16 02:29:17]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-16 02:29:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps100001
(title: "Fix remaining incorrect dependencies in BUILD.gn files.")

[commit-bot: I haz the power, 2016-12-16 02:30:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 02:37:43]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hansberry, 2016-12-16 02:45:09]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-16 02:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps120001
(title: "More dependency corrections in BUILD.gn files.")

[commit-bot: I haz the power, 2016-12-16 02:45:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:08:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hansberry, 2016-12-16 19:09:42]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-16 19:09:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps140001
(title: "Unit test fixes.")

[commit-bot: I haz the power, 2016-12-16 19:10:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 20:06:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ryan Hansberry, 2016-12-16 21:04:07]

hansberry@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2016-12-17 00:52:09]

cryptauth/DEPS use of device/bluetooth LGTM, as a move from proximity_auth/DEPS.

Save me time on the next patch by writing why you're adding me as a reviewer.

components/cryptauth/README should exist.

[Ryan Hansberry, 2016-12-17 01:25:50]

On 2016/12/17 00:52:09, scheib OOO wrote:
> cryptauth/DEPS use of device/bluetooth LGTM, as a move from
proximity_auth/DEPS.
> 
> Save me time on the next patch by writing why you're adding me as a reviewer.
> 
> components/cryptauth/README should exist.

Apologies for that! And README added.

[Ryan Hansberry, 2016-12-17 01:28:30]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-17 01:28:31]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps160001
(title: "Add components/cryptauth/README.")

[commit-bot: I haz the power, 2016-12-17 01:28:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 03:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 03:46:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hansberry, 2016-12-19 19:22:03]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2016-12-19 19:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
khorimoto@chromium.org, tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2561203002/#ps180001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-12-19 19:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 22:19:26]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1482175323712580,
"parent_rev": "47b6aa84f5de0fc2d962741bf012a6182564d515", "commit_rev":
"85a448873794ba9f13fd0b1d9b241e58373824ed"}

[commit-bot: I haz the power, 2016-12-19 22:19:50]

Description was changed from

==========
Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

This is the first part of a larger migration of some parts of proximity_auth
into cryptauth.

BUG=672263
==========

to

==========
Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

This is the first part of a larger migration of some parts of proximity_auth
into cryptauth.

BUG=672263

Review-Url: https://codereview.chromium.org/2561203002
==========

[commit-bot: I haz the power, 2016-12-19 22:19:52]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-12-19 22:23:31]

Description was changed from

==========
Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

This is the first part of a larger migration of some parts of proximity_auth
into cryptauth.

BUG=672263

Review-Url: https://codereview.chromium.org/2561203002
==========

to

==========
Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.

This is the first part of a larger migration of some parts of proximity_auth
into cryptauth.

BUG=672263

Committed: https://crrev.com/e7ad389b8dc346d0167af4b836144f1fbc5e2cd8
Cr-Commit-Position: refs/heads/master@{#439587}
==========

[commit-bot: I haz the power, 2016-12-19 22:23:33]

Patchset 10 (id:??) landed as
https://crrev.com/e7ad389b8dc346d0167af4b836144f1fbc5e2cd8
Cr-Commit-Position: refs/heads/master@{#439587}

[Kyle Horimoto, 2017-01-14 00:00:13]

https://codereview.chromium.org/2561203002/diff/180001/components/cryptauth/b...
File
components/cryptauth/ble/bluetooth_low_energy_characteristics_finder_unittest.cc
(right):

https://codereview.chromium.org/2561203002/diff/180001/components/cryptauth/b...
components/cryptauth/ble/bluetooth_low_energy_characteristics_finder_unittest.cc:53:
class ProximityAuthBluetoothLowEnergyCharacteristicFinderTest
nit: Just realized that you forgot to rename these tests from ProximityAuth* to
CryptAuth*. Please do so in a follow-up CL. Thanks!