On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> This should have been removed when I made the move originally; can you please
> remove it in this CL?
Unfortunately it seems that cryptauth depends on proximity/logging in some
places. Would you like me to remove that dependency in this CL? (It may be
better to punt it to another CL)
Kyle Horimoto
2016/12/09 01:25:09
Make this depend on logging instead of the entire
On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > This should have been removed when I made the move originally; can you
please
> > remove it in this CL?
>
> Unfortunately it seems that cryptauth depends on proximity/logging in some
> places. Would you like me to remove that dependency in this CL? (It may be
> better to punt it to another CL)
Make this depend on logging instead of the entire package then.
Ryan Hansberry
2016/12/09 02:36:50
Unfortunately cryptauth also depends on proximity_
On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > This should have been removed when I made the move originally; can you
> please
> > > remove it in this CL?
> >
> > Unfortunately it seems that cryptauth depends on proximity/logging in some
> > places. Would you like me to remove that dependency in this CL? (It may be
> > better to punt it to another CL)
>
> Make this depend on logging instead of the entire package then.
Unfortunately cryptauth also depends on
proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies to
just that and proximity_auth/logging.
Kyle Horimoto
2016/12/09 18:07:46
Can you move that file over to cryptauth as well?
On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > > This should have been removed when I made the move originally; can you
> > please
> > > > remove it in this CL?
> > >
> > > Unfortunately it seems that cryptauth depends on proximity/logging in some
> > > places. Would you like me to remove that dependency in this CL? (It may be
> > > better to punt it to another CL)
> >
> > Make this depend on logging instead of the entire package then.
>
> Unfortunately cryptauth also depends on
> proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies
to
> just that and proximity_auth/logging.
Can you move that file over to cryptauth as well? Thanks!
Ryan Hansberry
2016/12/09 20:11:05
Done, and renamed to cryptauth_test_util.
On 2016/12/09 18:07:46, Kyle Horimoto wrote:
> On 2016/12/09 02:36:50, Ryan Hansberry wrote:
> > On 2016/12/09 01:25:09, Kyle Horimoto wrote:
> > > On 2016/12/09 01:18:14, Ryan Hansberry wrote:
> > > > On 2016/12/08 21:52:40, Kyle Horimoto wrote:
> > > > > This should have been removed when I made the move originally; can you
> > > please
> > > > > remove it in this CL?
> > > >
> > > > Unfortunately it seems that cryptauth depends on proximity/logging in
some
> > > > places. Would you like me to remove that dependency in this CL? (It may
be
> > > > better to punt it to another CL)
> > >
> > > Make this depend on logging instead of the entire package then.
> >
> > Unfortunately cryptauth also depends on
> > proximity_auth/proximity_auth_test_util.h, but I've reduced the dependencies
> to
> > just that and proximity_auth/logging.
>
> Can you move that file over to cryptauth as well? Thanks!
Issue 2561203002: Migrate weave-related classes from proximity_auth/ble to cryptauth/ble.
(Closed)
Created 4 years ago by Ryan Hansberry
Modified 3 years, 11 months ago
Reviewers: Kyle Horimoto, Tim Song, scheib
Base URL:
Comments: 20
Chromium Code Reviews
Issue 2561203002:
Migrate weave-related classes from proximity_auth/ble to cryptauth/ble. (Closed)
