Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceReques…

Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5749f7cbdd6f9cb4915925f1418ef1772ec0168f
Cr-Commit-Position: refs/heads/master@{#438037}

[yzshen1, 2016-12-08 21:51:29]

Description was changed from

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
==========

to

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yzshen1, 2016-12-08 21:51:36]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 21:52:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:23:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yzshen1, 2016-12-08 22:32:55]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 22:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-08 22:51:00]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 22:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:11:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2016-12-09 00:57:35]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:22:01]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yzshen1, 2016-12-09 19:18:21]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 19:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 19:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:41:49]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yzshen1, 2016-12-09 22:13:56]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 22:14:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 22:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 22:41:17]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yzshen1, 2016-12-09 22:48:38]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 22:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-10 00:45:33]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 00:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:08:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2016-12-12 22:30:42]

yzshen@chromium.org changed reviewers:
+ eugenebut@chromium.org, jam@chromium.org, rockot@chromium.org

[yzshen1, 2016-12-12 22:30:43]

Hi, reviewers.

Would you please take a look?

This CL doesn't switch all usage of the "connection" module to the "bindings"
module of the JS bindings. Instead it just does the minimal change so that
existing code won't break with the new auto-generated code for interface
pointer/request.

Ken: everything
Eugene: IOS related files
John: owner review for chrome/* and content/* files.

Thanks!

[yzshen1, 2016-12-12 22:30:53]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 22:33:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-12-12 22:35:32]

ios lgtm

[yzshen1, 2016-12-12 22:39:49]

https://codereview.chromium.org/2556353004/diff/140001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2556353004/diff/140001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:66: return "new
%sPtr()" % JavaScriptType(field.kind)
Because FooPtr and InterfaceRequest objects have their own "invalid" state, I
always use that instead of "null" for null interface pointer / request that we
pass to the user code. On the other hand, when the user code passes us null
interface pointer / request, I allow both "null" and invalid FooPtr /
InterfaceRequest.

[Ken Rockot(use gerrit already), 2016-12-12 23:48:07]

lgtm

https://codereview.chromium.org/2556353004/diff/140001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2556353004/diff/140001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:66: return "new
%sPtr()" % JavaScriptType(field.kind)
On 2016/12/12 at 22:39:49, yzshen1 wrote:
> Because FooPtr and InterfaceRequest objects have their own "invalid" state, I
always use that instead of "null" for null interface pointer / request that we
pass to the user code. On the other hand, when the user code passes us null
interface pointer / request, I allow both "null" and invalid FooPtr /
InterfaceRequest.

Makes sense

[commit-bot: I haz the power, 2016-12-13 00:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:37:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[jam, 2016-12-13 01:40:02]

rubberstamp lgtm

[yzshen1, 2016-12-13 02:08:00]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:42:51]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481594880529040,
"parent_rev": "cfbf21a5745e1cb7d56ef2617ef513e3c743ed62", "commit_rev":
"5ccce0655ad535988ef198d8c4ef69fd04d927e0"}

[commit-bot: I haz the power, 2016-12-13 03:43:17]

Description was changed from

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556353004
==========

[commit-bot: I haz the power, 2016-12-13 03:43:18]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-13 03:46:30]

Description was changed from

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2556353004
==========

to

==========
Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr
and InterfaceRequest.

BUG=579646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5749f7cbdd6f9cb4915925f1418ef1772ec0168f
Cr-Commit-Position: refs/heads/master@{#438037}
==========

[commit-bot: I haz the power, 2016-12-13 03:46:31]

Patchset 8 (id:??) landed as
https://crrev.com/5749f7cbdd6f9cb4915925f1418ef1772ec0168f
Cr-Commit-Position: refs/heads/master@{#438037}