Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2563593005: Mojo JS bindings: lazily initialize the underlying connection of interface ptr. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: lazily initialize the underlying connection of interface ptr. This is useful when the user creates a bound interface ptr and passes it without actually using it to make any calls, which is pretty common. BUG=579646 Committed: https://crrev.com/348e013f762e7b9cb552e8cde4ac7490f7843742 Cr-Commit-Position: refs/heads/master@{#437957}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -31 lines) Patch
M mojo/public/js/bindings.js View 1 6 chunks +59 lines, -30 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
yzshen1
Hi, Ken. Please take a look. I somehow forgot to do this in the initial ...
4 years ago (2016-12-09 23:47:33 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-12 22:53:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563593005/20001
4 years ago (2016-12-12 23:00:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 23:37:07 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 23:38:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/348e013f762e7b9cb552e8cde4ac7490f7843742
Cr-Commit-Position: refs/heads/master@{#437957}

Powered by Google App Engine
This is Rietveld 408576698