Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: mojo/edk/js/tests/sample_service_tests.js

Issue 2556353004: Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceReques… (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/js/tests/sample_service_tests.js
diff --git a/mojo/edk/js/tests/sample_service_tests.js b/mojo/edk/js/tests/sample_service_tests.js
index 71aa48cfe764faaa66fda1a5d9ab1580baf6b0f7..b9a28458142d683b85557794a02c62936f87de51 100644
--- a/mojo/edk/js/tests/sample_service_tests.js
+++ b/mojo/edk/js/tests/sample_service_tests.js
@@ -73,7 +73,7 @@ define([
ServiceImpl.prototype.frobinate = function(foo, baz, port) {
checkFoo(foo);
expect(baz).toBe(sample.Service.BazOptions.EXTRA);
- bindings.ProxyBindings(port).close();
+ expect(port.ptr.isBound()).toBeTruthy();
return Promise.resolve({result: 1234});
};
@@ -85,9 +85,10 @@ define([
var serviceBinding = new bindings.Binding(
sample.Service, new ServiceImpl(), request);
- var pipe = core.createMessagePipe();
+ var port = new sample.PortPtr();
+ bindings.makeRequest(port);
var promise = service.frobinate(
- foo, sample.Service.BazOptions.EXTRA, pipe.handle0)
+ foo, sample.Service.BazOptions.EXTRA, port)
.then(function(response) {
expect(response.result).toBe(1234);

Powered by Google App Engine
This is Rietveld 408576698