mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl - Issue 2556353004: Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceReques…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl

Issue 2556353004: Mojo JS bindings: code generator maps interface ptr and request to InterfacePtr and InterfaceReques… (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl b/mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl

index 3d0be6e95e334b97e3834b8d6e57baae9f5a9aa2..d4e15a7859607061dcaf9f7aa17eaaf596d02178 100644

--- a/mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl

@@ -6,7 +6,7 @@ if (err !== validator.validationError.NONE)

{%- macro _validate_field(field, offset, name) %}

{%- if field|is_string_pointer_field %}

// validate {{name}}

-err = messageValidator.validateStringPointer({{offset}}, {{field|validate_string_params}})

+err = messageValidator.validateStringPointer({{offset}}, {{field|validate_nullable_params}})

{%- elif field|is_array_pointer_field %}

// validate {{name}}

@@ -22,11 +22,15 @@ err = messageValidator.validateMapPointer({{offset}}, {{field|validate_map_param

{%- elif field|is_interface_field %}

// validate {{name}}

-err = messageValidator.validateInterface({{offset}}, {{field|validate_interface_params}});

+err = messageValidator.validateInterface({{offset}}, {{field|validate_nullable_params}});

-{%- elif field|is_handle_field or field|is_interface_request_field %}

+{%- elif field|is_interface_request_field %}

// validate {{name}}

-err = messageValidator.validateHandle({{offset}}, {{field|validate_handle_params}})

+err = messageValidator.validateInterfaceRequest({{offset}}, {{field|validate_nullable_params}})

+{{_check_err()}}

+{%- elif field|is_handle_field %}

+// validate {{name}}

+err = messageValidator.validateHandle({{offset}}, {{field|validate_nullable_params}})

{%- elif field|is_enum_field %}

// validate {{name}}