Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2550643002: [debug] Reland debug API removal (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] Reland debug API removal Removes debugCommandProcessor functionality. This is a reland of https://codereview.chromium.org/2524323002 https://codereview.chromium.org/2531543002 BUG=v8:5510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -557 lines) Patch
M src/api.cc View 4 chunks +7 lines, -32 lines 0 comments Download
M src/debug/debug.h View 7 chunks +3 lines, -116 lines 0 comments Download
M src/debug/debug.cc View 17 chunks +19 lines, -402 lines 0 comments Download
M src/execution.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (5 generated)
Yang
4 years ago (2016-12-02 08:34:02 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698