[debug] remove deprecated debug command message queue.

[debug] remove deprecated debug command message queue.

R=jgruber@chromium.org
BUG=v8:5510
Committed: https://crrev.com/abdbfc953d8d3b7cece335b9b56a323a8bd52ec4
Cr-Commit-Position: refs/heads/master@{#41259}

[jgruber, 2016-11-24 12:09:52]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 12:10:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-24 12:10:13]

lgtm

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (left):

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc#oldcode1833
src/debug/debug.cc:1833: if ((event != v8::Break || !auto_continue) &&
!event_listener_.is_null()) {
Is it ok to remove special handling for v8::Break events?

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc#newcode2119
src/debug/debug.cc:2119: // Isolate::context() may have been NULL when "script
collected" event
Does such an event still exist?

[commit-bot: I haz the power, 2016-11-24 12:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 12:15:52]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/13145)

[Yang, 2016-11-24 12:28:49]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-24 12:28:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2524323002/#ps40001
(title: "git cl set_commit")

[commit-bot: I haz the power, 2016-11-24 12:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-11-24 12:28:54]

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (left):

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc#oldcode1833
src/debug/debug.cc:1833: if ((event != v8::Break || !auto_continue) &&
!event_listener_.is_null()) {
On 2016/11/24 12:10:13, jgruber wrote:
> Is it ok to remove special handling for v8::Break events?

In fact, we have to. auto_continue can only be true when the debug command
message queue is being used. Otherwise it is false.

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2524323002/diff/1/src/debug/debug.cc#newcode2119
src/debug/debug.cc:2119: // Isolate::context() may have been NULL when "script
collected" event
On 2016/11/24 12:10:13, jgruber wrote:
> Does such an event still exist?

You are right. Not anymore. But I'm a bit hesitant to remove this check for now.

[commit-bot: I haz the power, 2016-11-24 12:55:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479990529154510,
"parent_rev": "418755eef6cc8aaa37776830e2d41f33ddb3a026", "commit_rev":
"7c03250ca3ca25c9b3d65324083a08344ec1a78b"}

[commit-bot: I haz the power, 2016-11-24 12:56:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-24 12:56:29]

Description was changed from

==========
[debug] remove deprecated debug command message queue.

R=jgruber@chromium.org
BUG=v8:5510
==========

to

==========
[debug] remove deprecated debug command message queue.

R=jgruber@chromium.org
BUG=v8:5510

Committed: https://crrev.com/abdbfc953d8d3b7cece335b9b56a323a8bd52ec4
Cr-Commit-Position: refs/heads/master@{#41259}
==========

[commit-bot: I haz the power, 2016-11-24 12:56:30]

Patchset 3 (id:??) landed as
https://crrev.com/abdbfc953d8d3b7cece335b9b56a323a8bd52ec4
Cr-Commit-Position: refs/heads/master@{#41259}

[jgruber, 2016-12-01 08:51:26]

On 2016/11/24 12:56:30, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/abdbfc953d8d3b7cece335b9b56a323a8bd52ec4
> Cr-Commit-Position: refs/heads/master@{#41259}

Manual revert in https://codereview.chromium.org/2537313005/