Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2531543002: [debug] mark more unused debug API as deprecated. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] mark more unused debug API as deprecated. R=jgruber@chromium.org BUG=v8:5510 Committed: https://crrev.com/d5ada19ce71f4fd74d0501966fbc2009c81c6573 Cr-Commit-Position: refs/heads/master@{#41283}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -114 lines) Patch
M include/v8-debug.h View 1 4 chunks +11 lines, -9 lines 0 comments Download
M src/api.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/debug.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/debug/debug.js View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 5 chunks +1 line, -64 lines 0 comments Download
M test/debugger/test-api.js View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
jgruber
lgtm https://codereview.chromium.org/2531543002/diff/1/test/debugger/test-api.js File test/debugger/test-api.js (right): https://codereview.chromium.org/2531543002/diff/1/test/debugger/test-api.js#newcode35 test/debugger/test-api.js:35: AfterCompile: 4, We can probably also remove BeforeCompile. ...
4 years ago (2016-11-24 15:27:04 UTC) #1
Yang
https://codereview.chromium.org/2531543002/diff/1/test/debugger/test-api.js File test/debugger/test-api.js (right): https://codereview.chromium.org/2531543002/diff/1/test/debugger/test-api.js#newcode35 test/debugger/test-api.js:35: AfterCompile: 4, On 2016/11/24 15:27:03, jgruber wrote: > We ...
4 years ago (2016-11-25 08:31:35 UTC) #2
jgruber
lgtm
4 years ago (2016-11-25 08:43:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531543002/20001
4 years ago (2016-11-25 09:09:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 09:10:56 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d5ada19ce71f4fd74d0501966fbc2009c81c6573 Cr-Commit-Position: refs/heads/master@{#41283}
4 years ago (2016-11-25 09:11:08 UTC) #13
jgruber
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2542873002/ by jgruber@chromium.org. ...
4 years ago (2016-12-01 08:23:39 UTC) #14
jgruber
4 years ago (2016-12-01 08:51:08 UTC) #15
Message was sent while issue was closed.
On 2016/12/01 08:23:39, jgruber wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2542873002/ by mailto:jgruber@chromium.org.
> 
> The reason for reverting is: Legacy debugging API is still in use by Node
> tests..

Manual revert in https://codereview.chromium.org/2537313005/

Powered by Google App Engine
This is Rietveld 408576698