Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2546473008: [debug] Partial reland of debug API removal (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] Partial reland of debug API deprecation This relands API deprecation (without removing the implementation), removal of NewFunction and BeforeCompile events, and removal of DebugCommandProcessor tests. The remaining portion of the original CLs can be relanded after the 4.7 branch point. Original CLs: https://codereview.chromium.org/2524323002 https://codereview.chromium.org/2531543002 BUG=v8:5510 Committed: https://crrev.com/1a6dae8070ee6ddb3f676acf3a0dac40871182e4 Cr-Commit-Position: refs/heads/master@{#41446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -91 lines) Patch
M include/v8-debug.h View 5 chunks +12 lines, -10 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/debug.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/debug/debug.js View 1 chunk +3 lines, -5 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 5 chunks +1 line, -62 lines 0 comments Download
M test/debugger/test-api.js View 1 chunk +2 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
Yang
lgtm. thanks. please go ahead and land.
4 years ago (2016-12-02 08:32:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546473008/1
4 years ago (2016-12-02 08:38:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 09:01:42 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 09:02:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a6dae8070ee6ddb3f676acf3a0dac40871182e4
Cr-Commit-Position: refs/heads/master@{#41446}

Powered by Google App Engine
This is Rietveld 408576698