Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int' (Closed)

Created:
6 years, 8 months ago by dw.im

Modified:
6 years, 7 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

expansionOpportunityCount should be 'unsigned' rather than 'int' Since the return type of expansionOpportunityCount function is 'unsigned', expansionOpportunityCount variable should be treated as 'unsigned'. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172780

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	Source/core/rendering/RenderBlock.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderRubyBase.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderRubyBase.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderRubyText.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderRubyText.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

leviw_travelin_and_unemployed

The CQ bit was checked by leviw@chromium.org

6 years, 7 months ago (2014-04-28 17:08:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/254803009/1

6 years, 7 months ago (2014-04-28 17:08:49 UTC) #3

Message was sent while issue was closed.

Change committed as 172780

Expand Messages | Collapse Messages