Source/core/rendering/RenderRubyBase.cpp - Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRubyBase.cpp

Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderRubyBase.cpp

diff --git a/Source/core/rendering/RenderRubyBase.cpp b/Source/core/rendering/RenderRubyBase.cpp

index 8d9c9ad1c369c4408d77980d060d0153f53cd28a..43d46ed0d04bed3c034eea0f9907ff414af91e76 100644

--- a/Source/core/rendering/RenderRubyBase.cpp

+++ b/Source/core/rendering/RenderRubyBase.cpp

@@ -135,7 +135,7 @@ ETextAlign RenderRubyBase::textAlignmentForLine(bool /* endsWithSoftBreak */) co

return JUSTIFY;

}

-void RenderRubyBase::adjustInlineDirectionLineBounds(int expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const

+void RenderRubyBase::adjustInlineDirectionLineBounds(unsigned expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const

{

int maxPreferredLogicalWidth = this->maxPreferredLogicalWidth();

if (maxPreferredLogicalWidth >= logicalWidth)

« no previous file with comments | « Source/core/rendering/RenderRubyBase.h ('k') | Source/core/rendering/RenderRubyText.h » ('j') | no next file with comments »