Source/core/rendering/RenderRubyBase.h - Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/RenderRubyBase.h

Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/rendering/RenderBlockLineLayout.cpp ('k') | Source/core/rendering/RenderRubyBase.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 virtual const char* renderName() const OVERRIDE { return "RenderRubyBase (an onymous)"; }	46 virtual const char* renderName() const OVERRIDE { return "RenderRubyBase (an onymous)"; }

47	47

48 virtual bool isRubyBase() const OVERRIDE { return true; }	48 virtual bool isRubyBase() const OVERRIDE { return true; }

49	49

50 virtual bool isChildAllowed(RenderObject, RenderStyle) const OVERRIDE;	50 virtual bool isChildAllowed(RenderObject, RenderStyle) const OVERRIDE;

51	51

52 private:	52 private:

53 RenderRubyBase();	53 RenderRubyBase();

54	54

55 virtual ETextAlign textAlignmentForLine(bool endsWithSoftBreak) const OVERRI DE;	55 virtual ETextAlign textAlignmentForLine(bool endsWithSoftBreak) const OVERRI DE;

56 virtual void adjustInlineDirectionLineBounds(int expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const OVERRIDE;	56 virtual void adjustInlineDirectionLineBounds(unsigned expansionOpportunityCo unt, float& logicalLeft, float& logicalWidth) const OVERRIDE;

57	57

58 void moveChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0);	58 void moveChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0);

59 void moveInlineChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0);	59 void moveInlineChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0);

60 void moveBlockChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0 );	60 void moveBlockChildren(RenderRubyBase* toBase, RenderObject* beforeChild = 0 );

61	61

62 // Allow RenderRubyRun to manipulate the children within ruby bases.	62 // Allow RenderRubyRun to manipulate the children within ruby bases.

63 friend class RenderRubyRun;	63 friend class RenderRubyRun;

64 };	64 };

65	65

66 } // namespace WebCore	66 } // namespace WebCore

67	67

68 #endif // RenderRubyBase_h	68 #endif // RenderRubyBase_h

OLD	NEW