Source/core/rendering/RenderRubyText.cpp - Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRubyText.cpp

Issue 254803009: expansionOpportunityCount should be 'unsigned' rather than 'int' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderRubyText.cpp

diff --git a/Source/core/rendering/RenderRubyText.cpp b/Source/core/rendering/RenderRubyText.cpp

index 3cbc0e557e07a9262577dccc9bff187b252ee0a4..5e4697873474f4c48032fbd818bf29cdb61cf4e0 100644

--- a/Source/core/rendering/RenderRubyText.cpp

+++ b/Source/core/rendering/RenderRubyText.cpp

@@ -62,7 +62,7 @@ ETextAlign RenderRubyText::textAlignmentForLine(bool endsWithSoftBreak) const

return JUSTIFY;

}

-void RenderRubyText::adjustInlineDirectionLineBounds(int expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const

+void RenderRubyText::adjustInlineDirectionLineBounds(unsigned expansionOpportunityCount, float& logicalLeft, float& logicalWidth) const

{

ETextAlign textAlign = style()->textAlign();

// FIXME: This check is bogus since user can set the initial value.

« no previous file with comments | « Source/core/rendering/RenderRubyText.h ('k') | no next file » | no next file with comments »