Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
254803002:
Making webrtc video quality test page generic (Closed)
|
Created:
6 years, 8 months ago by amogh.bihani Modified:
6 years, 7 months ago CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionMaking webrtc video quality test page generic
This CL makes the webrtc video quality test page generic so that the
same page can be used for more than one tests. The paramters are now extracted from the video stream itself.
BUG=286290
TEST=out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest* --run-manual --ui-test-action-max-timeout=150000
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270034
Patch Set 1 #
Total comments: 1
Patch Set 2 : Taking dimensions from the video stream itself #
Total comments: 13
Patch Set 3 : addressing comments, removing global variables #Patch Set 4 : removing nits #
Total comments: 2
Patch Set 5 : addressing comments #
Total comments: 17
Patch Set 6 : Passing reference instead of id #Patch Set 7 : Seting canvas dimensions externally #
Total comments: 3
Patch Set 8 : Removing hd test html file #Patch Set 9 : #
Messages
Total messages: 32 (0 generated)
PTAL. I have made the test page generic as discussed on the thread.
https://codereview.chromium.org/254803002/diff/1/chrome/test/data/webrtc/webr... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/1/chrome/test/data/webrtc/webr... chrome/test/data/webrtc/webrtc_video_quality_test.html:12: // The test page will take default value if any of the parameters I think you can make this even smarter. The video tag will adapt its size to the source stream if you don't force its height and width by specifying it. So you need the dimensions to tell startFrameCapture what to capture. However, you should be able to rewrite startFrameCapture to look at a particular video tag, and query videoWidth and videoHeight for that video tag instead. Please try that out instead of passing parameters to the page.
Thanks for the review :) I have made the changes as advised.
Thanks for the changes! I think the general approach is sound, but I think we can do it with a bit less code and less globals. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:106: * parameters are to be extracted Nit: End with . https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:113: extractParameters(videoTagName); Adding globals for height and width is a step backwards. Keep the parameters to shoot() but pass in video.videoWidth as the width, etc. What about something like this: var video = document.getElementById(videoTagName); if (!video) failTest('Did not find element ' + videoTagName + '.'); if (video.videoWidth == 0 || video.videoHeight == 0) failTest('Trying to capture from ' + videoTagName + ' but it is not playing video'); ... setTimeout(function() { shoot(video.videoWidth, video.videoHeight); }, gFrameCaptureInterval); You can get rid of the whole canvas height thing. I haven't seen us capture anything else than the whole feed, so keeping it seems like unnecessary flexibility. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:137: if (gVideoHeight == undefined || gVideoWidth == undefined || This error checking for undefined will not really do anything, as localView.videoHeight will throw if localView is null. Write the error checks like I suggested above instead. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:145: var remoteView = document.getElementById(gVideoId); This and 149-157 really seems to have no function but make the web page look nicer. This code doesn't belong in video_extraction.js and it certainly doesn't belong in a function called extractParameters. Just try deleting the code. If you still feel you need it, put it somewhere else like in the video quality test HTML page (for instance, when you invoke startFrameCapture(...), also invoke makeWebpageLookPretty(...) and put the prettifying code in there). https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:149: var remoteCanvas = document.getElementById(gCanvasId); I'm pretty sure you don't need to set the dimensions of the canvas; I think it will figure out how big it needs to be by itself. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:171: var canvas = document.getElementById(gCanvasId); This is a good idea (we should get rid of the hard-coded canvas name though and create the canvas on the fly, but you don't have to do that this patch). https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:183: function shoot() { Like I said above, keep the parameters for width and height, throw away canvas_height and delete 205-208 (which isn't used anyway).
Thanks :) I have made the changes. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:106: * parameters are to be extracted On 2014/04/28 08:51:43, phoglund wrote: > Nit: End with . Done. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:113: extractParameters(videoTagName); On 2014/04/28 08:51:43, phoglund wrote: > Adding globals for height and width is a step backwards. Keep the parameters to > shoot() but pass in video.videoWidth as the width, etc. > > What about something like this: > > var video = document.getElementById(videoTagName); > if (!video) > failTest('Did not find element ' + videoTagName + '.'); > if (video.videoWidth == 0 || video.videoHeight == 0) > failTest('Trying to capture from ' + videoTagName + ' but it is not playing > video'); > > ... > > setTimeout(function() { shoot(video.videoWidth, video.videoHeight); }, > gFrameCaptureInterval); > > You can get rid of the whole canvas height thing. I haven't seen us capture > anything else than the whole feed, so keeping it seems like unnecessary > flexibility. Done. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:137: if (gVideoHeight == undefined || gVideoWidth == undefined || On 2014/04/28 08:51:43, phoglund wrote: > This error checking for undefined will not really do anything, as > localView.videoHeight will throw if localView is null. Write the error checks > like I suggested above instead. Done. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:145: var remoteView = document.getElementById(gVideoId); On 2014/04/28 08:51:43, phoglund wrote: > This and 149-157 really seems to have no function but make the web page look > nicer. This code doesn't belong in video_extraction.js and it certainly doesn't > belong in a function called extractParameters. Just try deleting the code. If > you still feel you need it, put it somewhere else like in the video quality test > HTML page (for instance, when you invoke startFrameCapture(...), also invoke > makeWebpageLookPretty(...) and put the prettifying code in there). Done. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:149: var remoteCanvas = document.getElementById(gCanvasId); On 2014/04/28 08:51:43, phoglund wrote: > I'm pretty sure you don't need to set the dimensions of the canvas; I think it > will figure out how big it needs to be by itself. Done. https://codereview.chromium.org/254803002/diff/20001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:183: function shoot() { On 2014/04/28 08:51:43, phoglund wrote: > Like I said above, keep the parameters for width and height, throw away > canvas_height and delete 205-208 (which isn't used anyway). Done.
lgtm with nits fixed https://codereview.chromium.org/254803002/diff/50001/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/50001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:160: img = ctx.getImageData(0, 0, width, height); Nit: merge lines 158 and 160. https://codereview.chromium.org/254803002/diff/50001/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/50001/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:30: onplay="startFrameCapture('local-view', 30, 5)"></video> Nit: indent should be 4 spaces here (like it was).
Thanks for the review :) I will commit this once https://codereview.chromium.org/247723006/ lands.
On 2014/04/28 11:40:06, amogh.bihani wrote: > Thanks for the review :) > I will commit this once https://codereview.chromium.org/247723006/ lands. SGTM. Thanks for the patch!
This does not lgtm yet, since it will likely break the test. Please have a look at my comments. But thanks for helping out here, there are plenty of improvements we can do to these tests. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:92: function startFrameCapture(videoTagName, frame_rate, duration) { I suggest changing the first param to be the HTML element object instead, like this: function startFrameCapture(videoTag, frame_rate, duration) { Then you should also document it using non-nullable annotation: {!Object} (see http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...) https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:96: var video = document.getElementById(videoTagName); ...then you can remove this lookup and also the check below. That should be safe since tests using this test page are checking for JS Console errors (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...). Then a failure to pass the object would cause the test to fail. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:125: var canvas = document.getElementById(gCanvasId); I think there's room for improvement here, creating the canvas dynamically instead, like: var canvas = document.createElement('canvas'); document.body.appendChild(canvas); It should only be done once though, possibly using a global variable to check if it's created or not (creating it in the startFrameCapture function seems nicer than in this function). That work can be done in a future CL though. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:12: <body onload="initialize()"> Make sure you remove this, since it will cause a JS console error since it no longer exists. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:30: onplay="startFrameCapture('local-view', 30, 5)"></video> 'local-view' here is wrong, it should be 'remote-view'. An even better solution is to pass a reference to the HTML element, like this: onplay="startFrameCapture(this, 30, 5)" https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:40: <canvas id="remote-canvas"></canvas> Now that you remove the size of the canvas, does it automatically resize to what's being put on it during the first frame being captured? I assume you have tested this?
https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:92: function startFrameCapture(videoTagName, frame_rate, duration) { On 2014/04/29 08:17:37, Henrik Kjellander wrote: > I suggest changing the first param to be the HTML element object instead, like > this: > function startFrameCapture(videoTag, frame_rate, duration) { > > Then you should also document it using non-nullable annotation: > {!Object} (see > http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...) And how do you get a ref to the video tag object in the onplay context? https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:125: var canvas = document.getElementById(gCanvasId); On 2014/04/29 08:17:37, Henrik Kjellander wrote: > I think there's room for improvement here, creating the canvas dynamically > instead, like: > var canvas = document.createElement('canvas'); > document.body.appendChild(canvas); > > It should only be done once though, possibly using a global variable to check if > it's created or not (creating it in the startFrameCapture function seems nicer > than in this function). > > That work can be done in a future CL though. Yeah, I suggested that too but in a future CL. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:30: onplay="startFrameCapture('local-view', 30, 5)"></video> On 2014/04/29 08:17:37, Henrik Kjellander wrote: > 'local-view' here is wrong, it should be 'remote-view'. > An even better solution is to pass a reference to the HTML element, like this: > onplay="startFrameCapture(this, 30, 5)" Yeah, I missed that; good catch.
https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:92: function startFrameCapture(videoTagName, frame_rate, duration) { On 2014/04/29 08:48:20, phoglund wrote: > On 2014/04/29 08:17:37, Henrik Kjellander wrote: > > I suggest changing the first param to be the HTML element object instead, like > > this: > > function startFrameCapture(videoTag, frame_rate, duration) { > > > > Then you should also document it using non-nullable annotation: > > {!Object} (see > > > http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...) > And how do you get a ref to the video tag object in the onplay context? Like this: startFrameCapture(this, 30, 5)
Thanks :) I have made the changes. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:92: function startFrameCapture(videoTagName, frame_rate, duration) { On 2014/04/29 08:17:37, Henrik Kjellander wrote: > I suggest changing the first param to be the HTML element object instead, like > this: > function startFrameCapture(videoTag, frame_rate, duration) { > > Then you should also document it using non-nullable annotation: > {!Object} (see > http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...) Done. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:96: var video = document.getElementById(videoTagName); On 2014/04/29 08:17:37, Henrik Kjellander wrote: > ...then you can remove this lookup and also the check below. That should be safe > since tests using this test page are checking for JS Console errors > (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...). > Then a failure to pass the object would cause the test to fail. Done. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:12: <body onload="initialize()"> On 2014/04/29 08:17:37, Henrik Kjellander wrote: > Make sure you remove this, since it will cause a JS console error since it no > longer exists. Done. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:30: onplay="startFrameCapture('local-view', 30, 5)"></video> On 2014/04/29 08:17:37, Henrik Kjellander wrote: > 'local-view' here is wrong, it should be 'remote-view'. > An even better solution is to pass a reference to the HTML element, like this: > onplay="startFrameCapture(this, 30, 5)" Done. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:40: <canvas id="remote-canvas"></canvas> On 2014/04/29 08:17:37, Henrik Kjellander wrote: > Now that you remove the size of the canvas, does it automatically resize to > what's being put on it during the first frame being captured? I assume you have > tested this? I think this would work as first two frames are nevertheless dropped. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...
Needs more work. https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:40: <canvas id="remote-canvas"></canvas> On 2014/04/29 10:38:53, amogh.bihani wrote: > On 2014/04/29 08:17:37, Henrik Kjellander wrote: > > Now that you remove the size of the canvas, does it automatically resize to > > what's being put on it during the first frame being captured? I assume you > have > > tested this? > > I think this would work as first two frames are nevertheless dropped. > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... I tried out your CL locally and it doesn't. The default size of a canvas element is 300x150 according to the spec: http://www.w3.org/TR/2012/WD-html5-author-20120329/the-canvas-element.html#th... Please set the size to match the video stream dynamically in the JS. This leads to that the captured video becomes useless and the barcodes are not possible to decode. I suggest you run the tests locally and ensure you get useful stats out of the test. Since the test doesn't have sanity checks for all values, you have to manually inspect the RESULT lines containing perf numbers and at least check the following metrics: * Unique_frames_count >0 * PSNR and SSIM have values for the frames * Max_repeated and Max_skipped are low (0-10 frames or so). Please try to setup the full toolchain locally (build chromium_builder_webrtc target in Chrome). The only tools you need in addition to the compile output is to have ffmpeg and zxing in the PATH, as mentioned at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...
https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... chrome/test/data/webrtc/webrtc_video_quality_test.html:40: <canvas id="remote-canvas"></canvas> I added the deps in gclient as mentioned in https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... but I always get connection time out. I think the svn repo is down. :( I tried with http://downforeveryoneorjustme.com/svn.chromium.org sas well. I'll do do it after it is up again.
On 2014/04/29 11:43:01, amogh.bihani wrote: > https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... > File chrome/test/data/webrtc/webrtc_video_quality_test.html (right): > > https://codereview.chromium.org/254803002/diff/30002/chrome/test/data/webrtc/... > chrome/test/data/webrtc/webrtc_video_quality_test.html:40: <canvas > id="remote-canvas"></canvas> > I added the deps in gclient as mentioned in > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... > but I always get connection time out. I think the svn repo is down. :( > I tried with http://downforeveryoneorjustme.com/svn.chromium.org sas well. > > I'll do do it after it is up again. That will only get you the required reference videos downloaded. Unfortunately we haven't spent time on figuring out if it's allowed to redistribute zxing and ffmpeg and if so, put them up on google storage as well. The fact that each platform will need its own copy makes it tedious to setup. You currently have to get the tools for your platform following the links: * zxing (see the CPP version at https://code.google.com/p/zxing) * ffmpeg 0.11.1 or compatible version (see http://www.ffmpeg.org)
I have added a function to set the correct canvas dimensions. Now the test looks identical. However, since the svn repo is down, I do not have the actual y4m and yuv files. I took some random y4m file, generated corresponding yuv file and tested. The test passed, but I can't be sure. :/
I tested PS#6 and it works. lgtm with a few nits. Let's keep any non-minor changes in a future CL instead. https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... File chrome/test/data/webrtc/video_extraction.js (right): https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:100: ' but it is not playing any video.'); nit: +3 indent https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:120: function setCanvasDimensions(width, height) { Prefix with _ and mark as @private since this is only called from inside this script (http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...). It's possible more functions here should be handled the same way (I haven't checked). https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... chrome/test/data/webrtc/video_extraction.js:120: function setCanvasDimensions(width, height) { IMO it would be nicer to pass the canvas Id as a parameter instead of accessing the global variable from the inside of this function. I guess the global gCanvasId and gVideoId is spread out already all over the place, so feel free to ignore this however.
On 2014/04/30 10:49:41, kjellander (OOO til May 6) wrote: > I tested PS#6 and it works. Sorry, I meant I tested PS#7. > > lgtm with a few nits. Let's keep any non-minor changes in a future CL instead. > > https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... > File chrome/test/data/webrtc/video_extraction.js (right): > > https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... > chrome/test/data/webrtc/video_extraction.js:100: ' but it is not playing any > video.'); > nit: +3 indent > > https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... > chrome/test/data/webrtc/video_extraction.js:120: function > setCanvasDimensions(width, height) { > Prefix with _ and mark as @private since this is only called from inside this > script > (http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...). > > It's possible more functions here should be handled the same way (I haven't > checked). > > https://codereview.chromium.org/254803002/diff/90001/chrome/test/data/webrtc/... > chrome/test/data/webrtc/video_extraction.js:120: function > setCanvasDimensions(width, height) { > IMO it would be nicer to pass the canvas Id as a parameter instead of accessing > the global variable from the inside of this function. > I guess the global gCanvasId and gVideoId is spread out already all over the > place, so feel free to ignore this however.
What's the next step for this one?
Sorry, I was out of office, hence could not follow up on this. Now we will commit this after making the necessary changes in the test cases.
PTAL. I have made the necessary changes.
On 2014/05/12 11:16:43, amogh.bihani wrote: > PTAL. > I have made the necessary changes. +r : tommi@ for chrome/browser/media/
lgtm
Looks like this is good for checkin.
The CQ bit was checked by amogh.bihani@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/254803002/130001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
The CQ bit was checked by amogh.bihani@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/254803002/130001
Message was sent while issue was closed.
Change committed as 270034 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
