Add HD browser test to WebRTC suite.

Add HD browser test to WebRTC suite.

Uses gtest parameterization for two of the WebRTC
browser tests so they can be re-run with different
constraints (and reference files).

To run 360p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*0 --run-manual --ui-test-action-max-timeout=300000
and 720p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*1 --run-manual --ui-test-action-max-timeout=600000

This CL should get a follow-up after 
https://codereview.chromium.org/254803002/ is landed 
(then webrtc_video_quality_test_hd.html can be removed).

We also really should look into making the test more hermetic
so ffmpeg and zxing is bundled and auto-downloaded on all the
target platforms (using Google storage).

BUG=286290
TEST=locally running the test on Linux, Mac and Windows.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266884

[kjellander_chromium, 2014-04-28 06:03:52]

phoglund: main review.
tommi: rs on chrome/browser/media/*

https://codereview.chromium.org/247723006/diff/1/chrome/browser/media/chrome_...
File chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc (right):

https://codereview.chromium.org/247723006/diff/1/chrome/browser/media/chrome_...
chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc:56:
"USERPROFILE";
This will make it possible to support the Chromium checkout being on a different
disk than the user's home dir, which wasn't previously supported since HOMEPATH
doesn't include the drive.

[tommi (sloooow) - chröme, 2014-04-28 07:51:15]

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
File chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc (right):

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc:77: typedef
std::tr1::tuple<const char*, int, int, const char*,
Are we still using tr1 in new code?
Regardless, I don't think this is very readable.

I'd rather want to have a struct with all the member variables you added to
WebRtcVideoQualityBrowserTest and then simply have a member variable of that
struct type in WebRtcVideoQualityBrowserTest instead.  Should be less code in
the end too.

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/web...
File chrome/browser/media/webrtc_browsertest_common.cc (right):

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/web...
chrome/browser/media/webrtc_browsertest_common.cc:58: if
(!HasYuvAndY4mFile(test::kReferenceFileName360p))
nit: what about:

return HasYuvAndY4mFile(test::kReferenceFileName360p) &&
       HasYuvAndY4mFile(test::kReferenceFileName720p);

[phoglund_chromium, 2014-04-28 09:16:29]

lgtm when tommi is happy with it.

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
File chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc (right):

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc:77: typedef
std::tr1::tuple<const char*, int, int, const char*,
On 2014/04/28 07:51:15, tommi wrote:
> Are we still using tr1 in new code?
> Regardless, I don't think this is very readable.
> 
> I'd rather want to have a struct with all the member variables you added to
> WebRtcVideoQualityBrowserTest and then simply have a member variable of that
> struct type in WebRtcVideoQualityBrowserTest instead.  Should be less code in
> the end too.
+1

[kjellander_chromium, 2014-04-28 09:30:29]

PTAL

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
File chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc (right):

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/chr...
chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc:77: typedef
std::tr1::tuple<const char*, int, int, const char*,
On 2014/04/28 07:51:15, tommi wrote:
> Are we still using tr1 in new code?
> Regardless, I don't think this is very readable.
> 
> I'd rather want to have a struct with all the member variables you added to
> WebRtcVideoQualityBrowserTest and then simply have a member variable of that
> struct type in WebRtcVideoQualityBrowserTest instead.  Should be less code in
> the end too.

Good suggestion, patch set #3 is much nicer and easy to read.

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/web...
File chrome/browser/media/webrtc_browsertest_common.cc (right):

https://codereview.chromium.org/247723006/diff/20001/chrome/browser/media/web...
chrome/browser/media/webrtc_browsertest_common.cc:58: if
(!HasYuvAndY4mFile(test::kReferenceFileName360p))
On 2014/04/28 07:51:15, tommi wrote:
> nit: what about:
> 
> return HasYuvAndY4mFile(test::kReferenceFileName360p) &&
>        HasYuvAndY4mFile(test::kReferenceFileName720p);

Done.

[tommi (sloooow) - chröme, 2014-04-28 10:13:05]

lgtm

[kjellander_chromium, 2014-04-28 13:17:55]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-04-28 13:18:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kjellander@chromium.org/247723006/60001

[commit-bot: I haz the power, 2014-04-28 14:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 14:21:14]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[kjellander_chromium, 2014-04-29 07:01:39]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:02:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kjellander@chromium.org/247723006/60001

[amogh.bihani, 2014-04-29 07:12:28]

On 2014/04/29 07:02:35, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/kjellander@chromium.org/247723006/60001

I think you might have to fix this first:
src\chrome\browser\media\chrome_webrtc_video_quality_browsertest.cc(350) : error
C2664: 'GURL net::test_server::EmbeddedTestServer::GetURL(const std::string &)
const' : cannot convert argument 1 from 'const base::FilePath::CharType *' to
'const std::string &'

[commit-bot: I haz the power, 2014-04-29 07:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:57:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[kjellander_chromium, 2014-04-29 08:30:01]

On 2014/04/29 07:12:28, amogh.bihani wrote:
> On 2014/04/29 07:02:35, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >
https://chromium-status.appspot.com/cq/kjellander@chromium.org/247723006/60001
> 
> I think you might have to fix this first:
> src\chrome\browser\media\chrome_webrtc_video_quality_browsertest.cc(350) :
error
> C2664: 'GURL net::test_server::EmbeddedTestServer::GetURL(const std::string &)
> const' : cannot convert argument 1 from 'const base::FilePath::CharType *' to
> 'const std::string &'

You're right, I only payed attention to the linux_chromium_chromeos_rel failure
(which was a flake).
Uploaded PS#4 now, that should work.

[kjellander_chromium, 2014-04-29 08:56:11]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-04-29 08:56:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kjellander@chromium.org/247723006/80001

[commit-bot: I haz the power, 2014-04-29 14:50:19]

Change committed as 266884