chrome/test/data/webrtc/webrtc_video_quality_test.html - Issue 254803002: Making webrtc video quality test page generic

Side by Side Diff: chrome/test/data/webrtc/webrtc_video_quality_test.html

Issue 254803002: Making webrtc video quality test page generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>WebRTC Automated Test</title>	4 <title>WebRTC Automated Test</title>

5 <script type="text/javascript" src="adapter.js"></script>	5 <script type="text/javascript" src="adapter.js"></script>

6 <script type="text/javascript" src="test_functions.js"></script>	6 <script type="text/javascript" src="test_functions.js"></script>

7 <script type="text/javascript" src="message_handling.js"></script>	7 <script type="text/javascript" src="message_handling.js"></script>

8 <script type="text/javascript" src="getusermedia.js"></script>	8 <script type="text/javascript" src="getusermedia.js"></script>

9 <script type="text/javascript" src="jsep01_call.js"></script>	9 <script type="text/javascript" src="jsep01_call.js"></script>

10 <script type="text/javascript" src="video_extraction.js"></script>	10 <script type="text/javascript" src="video_extraction.js"></script>

11 </head>	11 </head>

12 <body>	12 <body onload="initialize()">
	kjellander_chromium 2014/04/29 08:17:37 Make sure you remove this, since it will cause a J Make sure you remove this, since it will cause a JS console error since it no longer exists. amogh.bihani 2014/04/29 10:38:53 Done. Show quoted text On 2014/04/29 08:17:37, Henrik Kjellander wrote: > Make sure you remove this, since it will cause a JS console error since it no > longer exists. Done.
13 <table border="0">	13 <table border="0">

14 <tr>	14 <tr>

15 <td>Local Preview</td>	15 <td>Local Preview</td>

16 <td>Remote Video</td>	16 <td>Remote Video</td>

17 </tr>	17 </tr>

18 <tr>	18 <tr>

19 <td>	19 <td>

20 <video width="640" height="360" id="local-view"	20 <video id="local-view" autoplay="autoplay"></video>

21 autoplay="autoplay"></video>

22 </td>	21 </td>

23 <td>	22 <td>

24 <!-- startFrameCapture() takes 5 parameters:	23 <!-- startFrameCapture() takes 5 parameters:

25 1. width: width of the video/canvas area.	24 1. width: width of the video/canvas area.

26 2. height: height of the video area.	25 2. height: height of the video area.

27 3. canvas_height: Height of the canvas.	26 3. canvas_height: Height of the canvas.

28 4. fps: fps at which we would like to sample.	27 4. fps: fps at which we would like to sample.

29 5. duration: The duration of the capturing. -->	28 5. duration: The duration of the capturing. -->

30 <video width="640" height="360" id="remote-view"	29 <video id="remote-view" autoplay="autoplay"

31 autoplay="autoplay" onplay="startFrameCapture(640,360,360,30,5)">	30 onplay="startFrameCapture('local-view', 30, 5)"></video>
	kjellander_chromium 2014/04/29 08:17:37 'local-view' here is wrong, it should be 'remote-v 'local-view' here is wrong, it should be 'remote-view'. An even better solution is to pass a reference to the HTML element, like this: onplay="startFrameCapture(this, 30, 5)" phoglund_chromium 2014/04/29 08:48:20 Yeah, I missed that; good catch. Show quoted text On 2014/04/29 08:17:37, Henrik Kjellander wrote: > 'local-view' here is wrong, it should be 'remote-view'. > An even better solution is to pass a reference to the HTML element, like this: > onplay="startFrameCapture(this, 30, 5)" Yeah, I missed that; good catch. amogh.bihani 2014/04/29 10:38:53 Done. Show quoted text On 2014/04/29 08:17:37, Henrik Kjellander wrote: > 'local-view' here is wrong, it should be 'remote-view'. > An even better solution is to pass a reference to the HTML element, like this: > onplay="startFrameCapture(this, 30, 5)" Done.
32 </video>

33 </td>	31 </td>

34 </tr>	32 </tr>

35 <tr>	33 <tr>

36 <td></td>	34 <td></td>

37 <td>	35 <td>

38 <div id="output" style="display: inline-block;	36 <div id="output">

39 position: relative; width: 640; height: 360">

40 <!-- Canvas height should be equal to video height if we want to	37 <!-- Canvas height should be equal to video height if we want to

41 capture the whole frames. If we only want to capture the barcode,	38 capture the whole frames. If we only want to capture the barcode,

42 canvas height should equal the barcode height. -->	39 canvas height should equal the barcode height. -->

43 <canvas id="remote-canvas" width="640" height="360"></canvas>	40 <canvas id="remote-canvas"></canvas>
	kjellander_chromium 2014/04/29 08:17:37 Now that you remove the size of the canvas, does i Now that you remove the size of the canvas, does it automatically resize to what's being put on it during the first frame being captured? I assume you have tested this? amogh.bihani 2014/04/29 10:38:53 I think this would work as first two frames are ne Show quoted text On 2014/04/29 08:17:37, Henrik Kjellander wrote: > Now that you remove the size of the canvas, does it automatically resize to > what's being put on it during the first frame being captured? I assume you have > tested this? I think this would work as first two frames are nevertheless dropped. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... kjellander_chromium 2014/04/29 11:28:16 I tried out your CL locally and it doesn't. The de Show quoted text On 2014/04/29 10:38:53, amogh.bihani wrote: > On 2014/04/29 08:17:37, Henrik Kjellander wrote: > > Now that you remove the size of the canvas, does it automatically resize to > > what's being put on it during the first frame being captured? I assume you > have > > tested this? > > I think this would work as first two frames are nevertheless dropped. > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... I tried out your CL locally and it doesn't. The default size of a canvas element is 300x150 according to the spec: http://www.w3.org/TR/2012/WD-html5-author-20120329/the-canvas-element.html#th... Please set the size to match the video stream dynamically in the JS. This leads to that the captured video becomes useless and the barcodes are not possible to decode. I suggest you run the tests locally and ensure you get useful stats out of the test. Since the test doesn't have sanity checks for all values, you have to manually inspect the RESULT lines containing perf numbers and at least check the following metrics: * Unique_frames_count >0 * PSNR and SSIM have values for the frames * Max_repeated and Max_skipped are low (0-10 frames or so). Please try to setup the full toolchain locally (build chromium_builder_webrtc target in Chrome). The only tools you need in addition to the compile output is to have ffmpeg and zxing in the PATH, as mentioned at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med... amogh.bihani 2014/04/29 11:43:02 I added the deps in gclient as mentioned in https: I added the deps in gclient as mentioned in https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w... but I always get connection time out. I think the svn repo is down. :( I tried with http://downforeveryoneorjustme.com/svn.chromium.org sas well. I'll do do it after it is up again.
44 </div>	41 </div>

45 </td>	42 </td>

46 </tr>	43 </tr>

47 </table>	44 </table>

48 </body>	45 </body>

49 </html>	46 </html>

OLD	NEW

« chrome/test/data/webrtc/video_extraction.js ('K') | « chrome/test/data/webrtc/video_extraction.js ('k') | no next file » | no next file with comments »