Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5177)

Unified Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 254803002: Making webrtc video quality test page generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webrtc/video_extraction.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
index edb42b04c4fe7e504bdb259b59144c7d71f3edc9..0ed5934bf3a5f1c152ed8265b138c6f360792fcb 100644
--- a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
@@ -67,6 +67,8 @@ static const base::FilePath::CharType kStatsFileName[] =
FILE_PATH_LITERAL("stats.txt");
static const char kMainWebrtcTestHtmlPage[] =
"/webrtc/webrtc_jsep01_test.html";
+static const char kCapturingWebrtcHtmlPage[] =
+ "/webrtc/webrtc_video_quality_test.html";
// If you change the port number, don't forget to modify video_extraction.js
// too!
@@ -76,16 +78,13 @@ static const struct VideoQualityTestConfig {
const char* test_name;
int width;
int height;
- const char* capture_page;
const base::FilePath::CharType* reference_video;
const char* constraints;
} kVideoConfigurations[] = {
{ "360p", 640, 360,
- "/webrtc/webrtc_video_quality_test.html",
test::kReferenceFileName360p,
WebRtcTestBase::kAudioVideoCallConstraints360p },
{ "720p", 1280, 720,
- "/webrtc/webrtc_video_quality_test_hd.html",
test::kReferenceFileName720p,
WebRtcTestBase::kAudioVideoCallConstraints720p },
};
@@ -341,7 +340,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
test_config_.constraints);
content::WebContents* right_tab =
OpenPageAndGetUserMediaInNewTabWithConstraints(
- embedded_test_server()->GetURL(test_config_.capture_page),
+ embedded_test_server()->GetURL(kCapturingWebrtcHtmlPage),
test_config_.constraints);
SetupPeerconnectionWithLocalStream(left_tab);
« no previous file with comments | « no previous file | chrome/test/data/webrtc/video_extraction.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698