Chromium Code Reviews

Issue 2546933002: [Turbofan] Add ARM NEON instructions for implementing SIMD. (Closed)

Created:
4 years ago by bbudge
Modified:
4 years ago
Reviewers:
Benedikt Meurer, martyn.capewell, Rodolph Perfetta (ARM), jbramley
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add ARM NEON instructions for implementing SIMD. - Adds NEON instructions to assembler, disassembler, simulator. - Adds ExtractLane, ReplaceLane functions to macro assembler. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2546933002 Cr-Commit-Position: refs/heads/master@{#41737} Committed: https://chromium.googlesource.com/v8/v8/+/03f33f2e68641903a982a025b0ba645c8ba9f9b3

Patch Set 1 #

Patch Set 2 : Restore deleted whitespace. #

Patch Set 3 : Fix disasm test. #

Patch Set 4 : Add NeonListOperand ctor overload for q-register. #

Patch Set 5 : Don't use temporary FP regs in tests. #

Total comments: 18

Patch Set 6 : Review comments. #

Total comments: 75

Patch Set 7 : Second review comments. #

Total comments: 30

Patch Set 8 : Third review comments. #

Total comments: 4

Patch Set 9 : Fourth review comments. #

Unified diffs Side-by-side diffs Stats (+1594 lines, -139 lines)
M src/arm/assembler-arm.h View 3 chunks +51 lines, -3 lines 0 comments
M src/arm/assembler-arm.cc View 7 chunks +301 lines, -25 lines 0 comments
M src/arm/constants-arm.h View 4 chunks +6 lines, -6 lines 0 comments
M src/arm/disasm-arm.cc View 7 chunks +159 lines, -15 lines 0 comments
M src/arm/macro-assembler-arm.h View 1 chunk +8 lines, -0 lines 0 comments
M src/arm/macro-assembler-arm.cc View 6 chunks +53 lines, -11 lines 0 comments
M src/arm/simulator-arm.h View 1 chunk +2 lines, -0 lines 0 comments
M src/arm/simulator-arm.cc View 9 chunks +411 lines, -57 lines 0 comments
M test/cctest/test-assembler-arm.cc View 7 chunks +257 lines, -22 lines 0 comments
M test/cctest/test-disasm-arm.cc View 3 chunks +101 lines, -0 lines 0 comments
M test/cctest/test-macro-assembler-arm.cc View 2 chunks +245 lines, -0 lines 0 comments

Messages

Total messages: 52 (38 generated)
bbudge
4 years ago (2016-12-02 01:17:31 UTC) #4
bbudge
ping.
4 years ago (2016-12-06 20:05:50 UTC) #15
Rodolph Perfetta (ARM)
partial review. https://codereview.chromium.org/2546933002/diff/80001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2546933002/diff/80001/src/arm/assembler-arm.cc#newcode3970 src/arm/assembler-arm.cc:3970: void Assembler::vcvt(const QwNeonRegister dst, const QwNeonRegister src, ...
4 years ago (2016-12-07 15:59:00 UTC) #19
bbudge
https://codereview.chromium.org/2546933002/diff/80001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2546933002/diff/80001/src/arm/assembler-arm.cc#newcode3970 src/arm/assembler-arm.cc:3970: void Assembler::vcvt(const QwNeonRegister dst, const QwNeonRegister src, On 2016/12/07 ...
4 years ago (2016-12-08 03:07:31 UTC) #22
Rodolph Perfetta (ARM)
https://codereview.chromium.org/2546933002/diff/100001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2546933002/diff/100001/src/arm/assembler-arm.cc#newcode3902 src/arm/assembler-arm.cc:3902: emit(0x1E7 * B23 | d * B22 | 3 ...
4 years ago (2016-12-08 18:08:28 UTC) #25
bbudge
Implemented the scalar - ARM core register move instructions. Extracted a utility method for simulator ...
4 years ago (2016-12-10 21:33:05 UTC) #26
bbudge
friendly ping
4 years ago (2016-12-14 01:20:08 UTC) #31
Rodolph Perfetta (ARM)
https://codereview.chromium.org/2546933002/diff/120001/src/arm/disasm-arm.cc File src/arm/disasm-arm.cc (right): https://codereview.chromium.org/2546933002/diff/120001/src/arm/disasm-arm.cc#newcode1553 src/arm/disasm-arm.cc:1553: out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, the assembler allows conditional ...
4 years ago (2016-12-14 12:06:31 UTC) #32
bbudge
https://codereview.chromium.org/2546933002/diff/120001/src/arm/disasm-arm.cc File src/arm/disasm-arm.cc (right): https://codereview.chromium.org/2546933002/diff/120001/src/arm/disasm-arm.cc#newcode1553 src/arm/disasm-arm.cc:1553: out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, On 2016/12/14 12:06:30, Rodolph ...
4 years ago (2016-12-14 19:14:49 UTC) #34
Rodolph Perfetta (ARM)
lgtm (only minor nits) you will need an owner approval though. https://codereview.chromium.org/2546933002/diff/140001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): ...
4 years ago (2016-12-14 20:27:08 UTC) #39
bbudge
Thanks Rodolph for the patient and thorough reviews. Hopefully future CLs will be simpler (no ...
4 years ago (2016-12-14 23:50:52 UTC) #43
bbudge
I'm going to test my OWNERS bit.
4 years ago (2016-12-15 18:13:31 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546933002/160001
4 years ago (2016-12-15 18:13:48 UTC) #49
commit-bot: I haz the power
4 years ago (2016-12-15 18:15:32 UTC) #52
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/03f33f2e68641903a982a025b0ba645c8ba...

Powered by Google App Engine