Rename canMakeActivePayment to canMakePayment

Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995
Committed: https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98
Cr-Commit-Position: refs/heads/master@{#436078}

[rwlbuis, 2016-12-01 20:12:35]

Description was changed from

==========
Rename canMakeActivePayment to canMakePayment

BUG=
==========

to

==========
Rename canMakeActivePayment to canMakePayment

BUG=587995
==========

[rwlbuis, 2016-12-01 20:14:02]

Description was changed from

==========
Rename canMakeActivePayment to canMakePayment

BUG=587995
==========

to

==========
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995
==========

[rwlbuis, 2016-12-01 22:30:58]

rob.buis@samsung.com changed reviewers:
+ rouslan@chromium.org

[rwlbuis, 2016-12-01 22:30:59]

PTAL.

I'll fix the build error soon (I think I forgot to update BUILD.gn) but maybe
you can already have a look.

[please use gerrit instead, 2016-12-01 23:48:36]

LGTM

Thank you so much for helping out here.

[rwlbuis, 2016-12-02 01:30:10]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-12-02 01:30:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2545523004/#ps60001
(title: "Try to fix build")

[commit-bot: I haz the power, 2016-12-02 01:31:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:38:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-12-02 01:40:06]

On 2016/12/02 01:38:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

WebKit LGTM

[rwlbuis, 2016-12-02 01:50:57]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-12-02 01:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:59:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-12-02 02:14:09]

rob.buis@samsung.com changed reviewers:
+ tsepez@chromium.org

[rwlbuis, 2016-12-02 02:14:10]

Adding tsepez for mojom review.

[rwlbuis, 2016-12-02 02:15:00]

rob.buis@samsung.com changed reviewers:
+ sky@chromium.org, thestig@chromium.org

[rwlbuis, 2016-12-02 02:15:00]

Adding sky/thestig for chrome/browser/payments/payment_request_impl.h review.

[please use gerrit instead, 2016-12-02 02:16:26]

On 2016/12/02 02:15:00, rwlbuis wrote:
> Adding sky/thestig for chrome/browser/payments/payment_request_impl.h review.

That's not necessary. Only payment_request.mojom needs approval.

[rwlbuis, 2016-12-02 02:43:06]

rob.buis@samsung.com changed reviewers:
- sky@chromium.org, thestig@chromium.org

[rwlbuis, 2016-12-02 15:51:08]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-12-02 15:51:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2545523004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-02 15:51:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-12-02 15:52:40]

You might want to wait for Tom to approve payment-request.mojom first.

[commit-bot: I haz the power, 2016-12-02 15:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 15:59:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-12-02 16:14:49]

On 2016/12/02 15:52:40, rouslan wrote:
> You might want to wait for Tom to approve payment-request.mojom first.

Right, I wanted to get buildbots green so once he approves it will go in
quickly. However I guess I have to rebase again :(

[rwlbuis, 2016-12-02 16:17:59]

Patchset #5 (id:80001) has been deleted

[Tom Sepez, 2016-12-02 17:37:27]

RS LGTM for renaming.

[rwlbuis, 2016-12-02 18:06:04]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-12-02 18:06:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2545523004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-02 18:06:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 18:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 18:14:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-12-02 18:34:46]

On 2016/12/02 02:16:26, rouslan wrote:
> On 2016/12/02 02:15:00, rwlbuis wrote:
> > Adding sky/thestig for chrome/browser/payments/payment_request_impl.h
review.
> 
> That's not necessary. Only payment_request.mojom needs approval.

It does seem necessary alas. Does chrome/browser/payments need OWNERS file too
maybe?
I'll add sky for this unless you know a way around this.

[please use gerrit instead, 2016-12-02 18:44:48]

Let's ask sky for review on chrome/browser/payments/. I have not placed an
OWNERS file in there yet, because I would like desktop expert oversight when we
develop the desktop implementation of PaymentRequest UI.

[rwlbuis, 2016-12-02 18:48:32]

rob.buis@samsung.com changed reviewers:
+ sky@chromium.org

[rwlbuis, 2016-12-02 18:48:33]

@sky PTAL chrome/browser/payments/payment_request_impl.h change.

[sky, 2016-12-02 18:59:15]

On 2016/12/02 18:48:33, rwlbuis wrote:
> @sky PTAL chrome/browser/payments/payment_request_impl.h change.

I think the ui should belong in c/b/ui/payments. So, if you want to put in
OWNERs file in c/b/payments, please do so.
chrome/browser/payments/payment_request_impl.h LGTM

[rwlbuis, 2016-12-02 19:09:53]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-12-02 19:10:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 23:37:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480705793095400,
"parent_rev": "ab91ad575bb829db0ba1188d7663e6537bcef855", "commit_rev":
"b2ba9bf2e63c2f159c356637d0fd851d1d53bfa7"}

[commit-bot: I haz the power, 2016-12-02 23:37:34]

Description was changed from

==========
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995
==========

to

==========
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995
==========

[commit-bot: I haz the power, 2016-12-02 23:37:35]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-02 23:39:35]

Description was changed from

==========
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995
==========

to

==========
Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG=587995

Committed: https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98
Cr-Commit-Position: refs/heads/master@{#436078}
==========

[commit-bot: I haz the power, 2016-12-02 23:39:36]

Patchset 5 (id:??) landed as
https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98
Cr-Commit-Position: refs/heads/master@{#436078}