chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java - Issue 2545523004: Rename canMakeActivePayment to canMakePayment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Issue 2545523004: Rename canMakeActivePayment to canMakePayment (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java ('k') | chrome/browser/payments/payment_request_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

index 5904a199a5be63689caee87d4abbc4597d6ede34..d2f1ea496bbd0ac26f0ff7c8b273ba4f9decce24 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

@@ -88,7 +88,7 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT

protected final CallbackHelper mUnableToAbort;

protected final CallbackHelper mBillingAddressChangeProcessed;

protected final CallbackHelper mShowFailed;

- protected final CallbackHelper mActivePaymentQueryResponded;

+ protected final CallbackHelper mCanMakePaymentQueryResponded;

protected final CallbackHelper mExpirationMonthChange;

protected PaymentRequestUI mUI;

@@ -114,7 +114,7 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT

mBillingAddressChangeProcessed = new CallbackHelper();

mExpirationMonthChange = new CallbackHelper();

mShowFailed = new CallbackHelper();

- mActivePaymentQueryResponded = new CallbackHelper();

+ mCanMakePaymentQueryResponded = new CallbackHelper();

mViewCoreRef = new AtomicReference<>();

mWebContentsRef = new AtomicReference<>();

mTestFilePath = UrlUtils.getIsolatedTestFilePath(

@@ -668,9 +668,9 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT

}

@Override

- public void onPaymentRequestServiceActivePaymentQueryResponded() {

+ public void onPaymentRequestServiceCanMakePaymentQueryResponded() {

ThreadUtils.assertOnUiThread();

- mActivePaymentQueryResponded.notifyCalled();

+ mCanMakePaymentQueryResponded.notifyCalled();

}

@Override