Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2542203004: blink: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, johnme+watch_chromium.org, eric.carlson_apple.com, Srirama, Yoav Weiss, krit, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Navid Zolghadr, ajuma+watch_chromium.org, mcasas+watch+mediastream_chromium.org, lushnikov+blink_chromium.org, loading-reviews_chromium.org, tommyw+watchlist_chromium.org, dcheng, jbroman+watch_chromium.org, dtapuska+blinkwatch_chromium.org, loading-reviews+parser_chromium.org, f(malita), fs, scheib+watch_chromium.org, ortuno+watch_chromium.org, kinuko+watch, rwlbuis, drott+blinkwatch_chromium.org, Mads Ager (chromium), aboxhall, iclelland+watch_chromium.org, szager+layoutwatch_chromium.org, chasej+watch_chromium.org, Rik, blink-reviews, gyuyoung2, falken+watch_chromium.org, caseq+blink_chromium.org, nhiroki, feature-vr-reviews_chromium.org, Nate Chapin, cbiesinger, shimazu+serviceworker_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, shimazu+worker_chromium.org, dtseng+watch_chromium.org, horo+watch_chromium.org, kouhei+heap_chromium.org, dshwang, dmazzoni+watch_chromium.org, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, blink-reviews-css, Justin Novosad, je_julie, jkarlin+watch_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, kenneth.christiansen, zoltan1, blink-reviews-layout_chromium.org, sof, jbroman, devtools-reviews_chromium.org, tyoshino+watch_chromium.org, glebl+reviews_chromium.org, mlamouri+watch-blink_chromium.org, harkness+watch_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, cmumford, Stephen Chennney, kinuko+fileapi, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, tzik, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, kouhei+svg_chromium.org, blink-reviews-wtf_chromium.org, pdr+graphicswatchlist_chromium.org, aboxhall+watch_chromium.org, blink-reviews-dom_chromium.org, gavinp+loader_chromium.org, pdr+svgwatchlist_chromium.org, blink-reviews-api_chromium.org, rjwright, blink-reviews-style_chromium.org, atotic+reviews_chromium.org, Peter Beverloo, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, darktears, loading-reviews+fetch_chromium.org, jsbell+idb_chromium.org, michaeln, nektar+watch_chromium.org, nektarios, kinuko+serviceworker, oilpan-reviews, danakj+watch_chromium.org, Mikhail, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in blink header files. This is not the first time such a cleanup is done for blink, but it should be the last as we have now an up-and-running presubmit check. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/a82fdc00a44f6b7bbdf3e254e4b3530e5acb5dba Cr-Commit-Position: refs/heads/master@{#436168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -238 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheets.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/WindowEventContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/BidiRun.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LayoutTextInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ScopedPageSuspender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathBlender.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerReportingProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/HostWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorAnimationHost.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultInlineHeaders.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PlaceholderImage.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GCInfo.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/WrapperVisitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FakeWebPlugin.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTraits.h View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebContentDecryptionModuleSession.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebContentLayerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebCookieJar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebDisplayItemList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebExternalBitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebFileWriter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFrameScheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebImageLayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayerEncryptedMediaClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCStatsRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/scheduler/base/task_queue.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/child/worker_scheduler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebAssociatedURLLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebAutofillClient.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgentClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDevToolsFrontend.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDocument.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebElementCollection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameSerializerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebInputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebLabelElement.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebPluginContainer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebRange.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebSharedWorkerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebSpellCheckClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jbriance
4 years ago (2016-12-02 15:17:56 UTC) #4
haraken
LGTM
4 years ago (2016-12-02 15:47:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203004/1
4 years ago (2016-12-03 08:43:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 20:53:36 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 20:56:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a82fdc00a44f6b7bbdf3e254e4b3530e5acb5dba
Cr-Commit-Position: refs/heads/master@{#436168}

Powered by Google App Engine
This is Rietveld 408576698