[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

This patch moves some of thre tracking info for waterfall and network datagrid
into NetworkDataGridNode. This is in an effort to remove as much dependency
on NetworkLogViewColumns as possible form waterfall.

R=dgozman
BUG=666971
Committed: https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995
Cr-Commit-Position: refs/heads/master@{#439991}

[allada, 2016-11-30 00:47:12]

Patchset #1 (id:1) has been deleted

[allada, 2016-11-30 00:47:20]

PTL

[allada, 2016-11-30 01:43:11]

Patchset #1 (id:20001) has been deleted

[dgozman, 2016-11-30 21:49:26]

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:267:
if (this.attached())
Why do you check for attached here, but not in other places?

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:274:
this._parentView.stylesChanged();
What will it take to turn this into event? Should be easier to understand then.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:278:
* @param {boolean} x
x -> showInitiatorChain

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:301:
* @param {boolean} x
x -> onInitiatorPath

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:318:
* @param {boolean} x
x -> onInitiatedPath

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:340:
nodeForRequest(request) {
JSDoc

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(left):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:178:
* @return {?Network.NetworkDataGridNode}
bring it back

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:63:
_onMouseMove(event) {
JSDoc

[allada, 2016-11-30 22:19:51]

PTL

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:267:
if (this.attached())
On 2016/11/30 21:49:26, dgozman wrote:
> Why do you check for attached here, but not in other places?

The reason is because the others should always be in the dom.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:274:
this._parentView.stylesChanged();
On 2016/11/30 21:49:26, dgozman wrote:
> What will it take to turn this into event? Should be easier to understand
then.

I could change it to trigger an event on _parentView, but I do not like the idea
of a Node triggering an event on LogView. If we trigger the event from the node
itself then as nodes get created and destroyed we'll have to remember to attach
and detach listeners on every node.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:278:
* @param {boolean} x
On 2016/11/30 21:49:26, dgozman wrote:
> x -> showInitiatorChain

Done.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:301:
* @param {boolean} x
On 2016/11/30 21:49:26, dgozman wrote:
> x -> onInitiatorPath

Done.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:318:
* @param {boolean} x
On 2016/11/30 21:49:26, dgozman wrote:
> x -> onInitiatedPath

Done.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:340:
nodeForRequest(request) {
On 2016/11/30 21:49:26, dgozman wrote:
> JSDoc

Done.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(left):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:178:
* @return {?Network.NetworkDataGridNode}
On 2016/11/30 21:49:26, dgozman wrote:
> bring it back

Done.

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2540893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:63:
_onMouseMove(event) {
On 2016/11/30 21:49:26, dgozman wrote:
> JSDoc

Done.

[dgozman, 2016-12-02 02:23:05]

lgtm

[allada, 2016-12-02 02:42:11]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:42:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 03:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 03:58:07]

Dry run: This issue passed the CQ dry run.

[allada, 2016-12-20 21:41:11]

Patchset #4 (id:100001) has been deleted

[allada, 2016-12-20 21:41:50]

Patchset #4 (id:120001) has been deleted

[allada, 2016-12-20 21:42:44]

PTaL, I rebased this code on other recent changes, so it should be ready to
commit now. The only file that changed that's worth mentioning is:
NetworkDataGridNode.js

[dgozman, 2016-12-21 00:25:12]

still lgtm

[allada, 2016-12-21 00:32:26]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:33:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:04:49]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482280346165610,
"parent_rev": "09514b02d29553d3fedec22dfe395440d6b887e1", "commit_rev":
"ed13647d055ffe4256bafdede48e99d31b9ebefb"}

[commit-bot: I haz the power, 2016-12-21 03:05:16]

Description was changed from

==========
[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

This patch moves some of thre tracking info for waterfall and network datagrid
into NetworkDataGridNode. This is in an effort to remove as much dependency
on NetworkLogViewColumns as possible form waterfall.

R=dgozman
BUG=666971
==========

to

==========
[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

This patch moves some of thre tracking info for waterfall and network datagrid
into NetworkDataGridNode. This is in an effort to remove as much dependency
on NetworkLogViewColumns as possible form waterfall.

R=dgozman
BUG=666971

Review-Url: https://codereview.chromium.org/2540893002
==========

[commit-bot: I haz the power, 2016-12-21 03:05:21]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-12-21 03:07:38]

Description was changed from

==========
[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

This patch moves some of thre tracking info for waterfall and network datagrid
into NetworkDataGridNode. This is in an effort to remove as much dependency
on NetworkLogViewColumns as possible form waterfall.

R=dgozman
BUG=666971

Review-Url: https://codereview.chromium.org/2540893002
==========

to

==========
[Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode

This patch moves some of thre tracking info for waterfall and network datagrid
into NetworkDataGridNode. This is in an effort to remove as much dependency
on NetworkLogViewColumns as possible form waterfall.

R=dgozman
BUG=666971

Committed: https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995
Cr-Commit-Position: refs/heads/master@{#439991}
==========

[commit-bot: I haz the power, 2016-12-21 03:07:39]

Patchset 4 (id:??) landed as
https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995
Cr-Commit-Position: refs/heads/master@{#439991}