Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2540893002: [Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode (Closed)
Patch Set: changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 72b947b5fb03901402e751f9e8ae4f04ceb5031b..3a5a3d898c60dcf9268f83f2e417d6f3933af91f 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -336,6 +336,14 @@ Network.NetworkLogView = class extends UI.VBox {
}
/**
+ * @param {!SDK.NetworkRequest} request
+ * @return {?Network.NetworkNode}
+ */
+ nodeForRequest(request) {
+ return this._nodesByRequestId.get(request.requestId);
+ }
+
+ /**
* @return {number}
*/
headerHeight() {
@@ -515,7 +523,7 @@ Network.NetworkLogView = class extends UI.VBox {
this._dataGrid.element.classList.add('network-log-grid');
this._dataGrid.element.addEventListener('mousedown', this._dataGridMouseDown.bind(this), true);
this._dataGrid.element.addEventListener('mousemove', this._dataGridMouseMove.bind(this), true);
- this._dataGrid.element.addEventListener('mouseleave', this._dataGridMouseLeave.bind(this), true);
+ this._dataGrid.element.addEventListener('mouseleave', () => this._setHoveredNode(null), true);
}
/**
@@ -526,21 +534,6 @@ Network.NetworkLogView = class extends UI.VBox {
/** @type {?Network.NetworkNode} */ (this._dataGrid.dataGridNodeFromNode(/** @type {!Node} */ (event.target)));
var highlightInitiatorChain = event.shiftKey;
this._setHoveredNode(node, highlightInitiatorChain);
- this._highlightInitiatorChain((highlightInitiatorChain && node) ? node.request() : null);
- }
-
- _dataGridMouseLeave() {
- this._setHoveredNode(null);
- this._highlightInitiatorChain(null);
- }
-
- /**
- * @param {?Network.NetworkNode} node
- * @param {boolean} highlightInitiatorChain
- */
- setHoveredNode(node, highlightInitiatorChain) {
- this._setHoveredNode(node, highlightInitiatorChain);
- this._highlightInitiatorChain((node && highlightInitiatorChain) ? node.request() : null);
}
/**
@@ -549,11 +542,10 @@ Network.NetworkLogView = class extends UI.VBox {
*/
_setHoveredNode(node, highlightInitiatorChain) {
if (this._hoveredNode)
- this._hoveredNode.element().classList.remove('hover');
+ this._hoveredNode.setHovered(false, false);
this._hoveredNode = node;
if (this._hoveredNode)
- this._hoveredNode.element().classList.add('hover');
- this._columns.setHoveredNode(this._hoveredNode, !!highlightInitiatorChain);
+ this._hoveredNode.setHovered(true, !!highlightInitiatorChain);
}
/**
@@ -564,35 +556,6 @@ Network.NetworkLogView = class extends UI.VBox {
event.consume();
}
- /**
- * @param {?SDK.NetworkRequest} request
- */
- _highlightInitiatorChain(request) {
- if (this._requestWithHighlightedInitiators === request)
- return;
- this._requestWithHighlightedInitiators = request;
-
- if (!request) {
- for (var node of this._nodesByRequestId.values()) {
- if (!node.dataGrid)
- continue;
- node.element().classList.remove('network-node-on-initiator-path', 'network-node-on-initiated-path');
- }
- return;
- }
-
- var initiatorGraph = request.initiatorGraph();
- for (var node of this._nodesByRequestId.values()) {
- if (!node.dataGrid)
- continue;
- node.element().classList.toggle(
- 'network-node-on-initiator-path',
- node.request() !== request && initiatorGraph.initiators.has(node.request()));
- node.element().classList.toggle(
- 'network-node-on-initiated-path', node.request() !== request && initiatorGraph.initiated.has(node.request()));
- }
- }
-
_updateSummaryBar() {
var requestsNumber = this._nodesByRequestId.size;
@@ -789,6 +752,10 @@ Network.NetworkLogView = class extends UI.VBox {
return this._dataGrid.rootNode().flatChildren();
}
+ stylesChanged() {
+ this._columns.scheduleRefresh();
+ }
+
_refresh() {
this._needsRefresh = false;

Powered by Google App Engine
This is Rietveld 408576698