Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2540893002: [Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode (Closed)
Patch Set: changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 8b52c9f7ddbc014bda961478b740c94f21df31f3..547090a537b3ecd35c276573911af94120e31f9a 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -122,13 +122,6 @@ Network.NetworkLogViewColumns = class {
this._waterfallColumn.element.addEventListener('mousewheel', this._onMouseWheel.bind(this, false), {passive: true});
this._dataGridScroller.addEventListener('mousewheel', this._onMouseWheel.bind(this, true), true);
- this._waterfallColumn.element.addEventListener('mousemove', event => {
- var hoveredNode = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.offsetY + event.target.offsetTop);
- this._networkLogView.setHoveredNode(hoveredNode, event.shiftKey);
- }, true);
- this._waterfallColumn.element.addEventListener(
- 'mouseleave', this._networkLogView.setHoveredNode.bind(this._networkLogView, null, false), true);
-
this._waterfallScroller = this._waterfallColumn.contentElement.createChild('div', 'network-waterfall-v-scroll');
this._waterfallScroller.addEventListener('scroll', this._syncScrollers.bind(this), {passive: true});
this._waterfallScrollerContent = this._waterfallScroller.createChild('div', 'network-waterfall-v-scroll-content');
@@ -171,8 +164,6 @@ Network.NetworkLogViewColumns = class {
event.consume(true);
this._activeScroller.scrollTop -= event.wheelDeltaY;
this._syncScrollers();
- var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.offsetY);
- this._networkLogView.setHoveredNode(node, event.shiftKey);
}
_syncScrollers() {
@@ -202,14 +193,6 @@ Network.NetworkLogViewColumns = class {
this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDividers, nodes);
}
- /**
- * @param {?Network.NetworkNode} node
- * @param {boolean} highlightInitiatorChain
- */
- setHoveredNode(node, highlightInitiatorChain) {
- this._waterfallColumn.setHoveredNode(node, highlightInitiatorChain);
- }
-
_createWaterfallHeader() {
this._waterfallHeaderElement = this._waterfallColumn.contentElement.createChild('div', 'network-waterfall-header');
this._waterfallHeaderElement.addEventListener('click', waterfallHeaderClicked.bind(this));
@@ -243,6 +226,10 @@ Network.NetworkLogViewColumns = class {
this._waterfallRequestsAreStale = true;
}
+ scheduleRefresh() {
+ this._waterfallColumn.scheduleDraw();
+ }
+
_updateRowsSize() {
var largeRows = !!this._networkLogLargeRowsSetting.get();
this._dataGrid.element.classList.toggle('small', !largeRows);

Powered by Google App Engine
This is Rietveld 408576698