Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2591043003: [Devtools] Setup network groupping to show bars for collapsed nodes (Closed)

Created:
4 years ago by allada
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Setup network groupping to show bars for collapsed nodes This patch will now show bars for nodes that are collapsed and contain nodes that have bars inside them. See: http://imgur.com/a/egUwg R=dgozman BUG=664704 Committed: https://crrev.com/31f31a2fa7d1367fa3472044adfbc746ceba1caf Cr-Commit-Position: refs/heads/master@{#440779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 3 chunks +10 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
allada
PTL
4 years ago (2016-12-21 01:09:37 UTC) #1
dgozman
lgtm
3 years, 12 months ago (2016-12-27 18:52:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591043003/1
3 years, 12 months ago (2016-12-27 18:54:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 20:20:06 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31f31a2fa7d1367fa3472044adfbc746ceba1caf
Cr-Commit-Position: refs/heads/master@{#440779}

Powered by Google App Engine
This is Rietveld 408576698