move common blur types into central header

move common blur types into central header

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14411

[reed1, 2014-04-28 15:36:56]

in service of (future CL) to expose asABlur to maskfilter and drawlooper

[scroggo, 2014-04-28 15:47:44]

https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
File gyp/skia_for_chromium_defines.gypi (right):

https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
gyp/skia_for_chromium_defines.gypi:24: 'SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE',
Will you please add this to gyp/common_conditions.gypi under
skia_android_framework?

https://codereview.chromium.org/253833002/diff/1/src/effects/SkBlurMask.h
File src/effects/SkBlurMask.h (left):

https://codereview.chromium.org/253833002/diff/1/src/effects/SkBlurMask.h#old...
src/effects/SkBlurMask.h:20: kNormal_Style,  //!< fuzzy inside and outside
+1 to removing duplicate code!

https://codereview.chromium.org/253833002/diff/20001/src/effects/SkBlurMaskFi...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/253833002/diff/20001/src/effects/SkBlurMaskFi...
src/effects/SkBlurMaskFilter.cpp:105: if (!(sigma > 0)) {
Can you add the comment (removed down below) about why you used ! > 0 instead of
<=0?

[reed1, 2014-04-28 15:57:54]

On 2014/04/28 15:47:44, scroggo wrote:
>
https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
> File gyp/skia_for_chromium_defines.gypi (right):
> 
>
https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
> gyp/skia_for_chromium_defines.gypi:24:
'SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE',
> Will you please add this to gyp/common_conditions.gypi under
> skia_android_framework?
> 
> https://codereview.chromium.org/253833002/diff/1/src/effects/SkBlurMask.h
> File src/effects/SkBlurMask.h (left):
> 
>
https://codereview.chromium.org/253833002/diff/1/src/effects/SkBlurMask.h#old...
> src/effects/SkBlurMask.h:20: kNormal_Style,  //!< fuzzy inside and outside
> +1 to removing duplicate code!
> 
>
https://codereview.chromium.org/253833002/diff/20001/src/effects/SkBlurMaskFi...
> File src/effects/SkBlurMaskFilter.cpp (right):
> 
>
https://codereview.chromium.org/253833002/diff/20001/src/effects/SkBlurMaskFi...
> src/effects/SkBlurMaskFilter.cpp:105: if (!(sigma > 0)) {
> Can you add the comment (removed down below) about why you used ! > 0 instead
of
> <=0?

Done

[reed1, 2014-04-28 15:58:01]

https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
File gyp/skia_for_chromium_defines.gypi (right):

https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
gyp/skia_for_chromium_defines.gypi:24: 'SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE',
On 2014/04/28 15:47:44, scroggo wrote:
> Will you please add this to gyp/common_conditions.gypi under
> skia_android_framework?

Done.

[scroggo, 2014-04-28 16:05:33]

On 2014/04/28 15:58:01, reed1 wrote:
>
https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
> File gyp/skia_for_chromium_defines.gypi (right):
> 
>
https://codereview.chromium.org/253833002/diff/1/gyp/skia_for_chromium_define...
> gyp/skia_for_chromium_defines.gypi:24:
'SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE',
> On 2014/04/28 15:47:44, scroggo wrote:
> > Will you please add this to gyp/common_conditions.gypi under
> > skia_android_framework?
> 
> Done.

lgtm

[reed1, 2014-04-28 16:06:35]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-28 16:06:48]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/253833002/40001

[commit-bot: I haz the power, 2014-04-28 16:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:07:25]

Failed to apply patch for gm/blurroundrect.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file gm/blurroundrect.cpp
  Hunk #2 FAILED at 120.
  1 out of 2 hunks FAILED -- saving rejects to file gm/blurroundrect.cpp.rej

Patch:       gm/blurroundrect.cpp
Index: gm/blurroundrect.cpp
diff --git a/gm/blurroundrect.cpp b/gm/blurroundrect.cpp
index
f688380f0e0253e6b96d6ca406c5fcd150d89c6d..15f3efc4a43aa14ba928955deaf1f5bf94bdc027
100644
--- a/gm/blurroundrect.cpp
+++ b/gm/blurroundrect.cpp
@@ -63,7 +63,7 @@ public:
             info.fPostTranslate = false;
             SkPaint* paint = looperBuilder.addLayerOnTop(info);
             SkMaskFilter* maskFilter = SkBlurMaskFilter::Create(
-                    SkBlurMaskFilter::kNormal_BlurStyle,
+                    kNormal_SkBlurStyle,
                     SkBlurMask::ConvertRadiusToSigma(SK_ScalarHalf),
                     SkBlurMaskFilter::kHighQuality_BlurFlag);
             paint->setMaskFilter(maskFilter)->unref();
@@ -120,7 +120,7 @@ protected:
             canvas->translate(0, (r.height() + SkIntToScalar(20)) * i);
             for (size_t j = 0; j < SK_ARRAY_COUNT(cornerRadii); ++j) {
                 SkMaskFilter* filter = SkBlurMaskFilter::Create(
-                    SkBlurMaskFilter::kNormal_BlurStyle,
+                    kNormal_SkBlurStyle,
                    
SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(blurRadii[i])));
                 SkPaint paint;
                 paint.setColor(SK_ColorBLUE);

[reed1, 2014-04-28 16:16:56]

The CQ bit was checked by reed@google.com

[reed1, 2014-04-28 16:16:58]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-04-28 16:17:00]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-28 16:17:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/253833002/50043

[commit-bot: I haz the power, 2014-04-28 16:25:59]

Change committed as 14411