Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Removed DataGrid's hasChildren getter/setter to use functions Removes DataGrid's hasChildren getter and setters and replaces them with respective function calls for get and set. R=dgozman BUG=None Committed: https://crrev.com/0aa1c00f79da9f34ae71635464deb34da0666574 Cr-Commit-Position: refs/heads/master@{#434821}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
allada
PTL
4 years ago (2016-11-28 21:51:37 UTC) #2
dgozman
lgtm
4 years ago (2016-11-29 00:36:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723003/1
4 years ago (2016-11-29 00:39:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:47:57 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 01:50:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aa1c00f79da9f34ae71635464deb34da0666574
Cr-Commit-Position: refs/heads/master@{#434821}

Powered by Google App Engine
This is Rietveld 408576698