third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js - Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

index efbb585aab4e0c2e883177847dcb737ee48f5984..9558cafe0a1473875e4c077cffca067409bce08e 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

@@ -631,7 +631,7 @@ Profiler.HeapSnapshotGenericObjectNode = class extends Profiler.HeapSnapshotGrid

* @this {Profiler.HeapSnapshotGenericObjectNode}

function isEmptyCallback(isEmpty) {

- this.hasChildren = !isEmpty;

+ this.setHasChildren(!isEmpty);

}

this._provider().isEmpty(isEmptyCallback.bind(this));

}