third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index f5eb97bd42a7c2698350aa32c27cc443eeb92e2b..26e3a93928ea8bead70521c68e6707df687220be 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -422,7 +422,7 @@ Timeline.TimelineTreeView.TreeGridNode = class extends Timeline.TimelineTreeView

constructor(profileNode, grandTotalTime, maxSelfTime, maxTotalTime, treeView) {

super(profileNode, grandTotalTime, maxSelfTime, maxTotalTime, treeView);

- this.hasChildren = this._profileNode.children ? this._profileNode.children.size > 0 : false;

+ this.setHasChildren(this._profileNode.children ? this._profileNode.children.size > 0 : false);

profileNode[Timeline.TimelineTreeView.TreeGridNode._gridNodeSymbol] = this;

}