third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js - Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

index 80afb4368ea91ec7c2c75e955e3a43aa421cb142..a447dc37bd944ec9c2aff7f244019b8c4bb945b5 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

@@ -390,9 +390,9 @@ Profiler.HeapSnapshotViewportDataGrid = class extends Profiler.HeapSnapshotSorta

var child = children[i];

if (nameFilterValue && child.filteredOut && child.filteredOut(nameFilterValue))

continue;

- var hasChildren = child.hasChildren;

+ var hasChildren = child.hasChildren();

child.removeChildren();

- child.hasChildren = hasChildren;

+ child.setHasChildren(hasChildren);

child.revealed = true;

parentNode.appendChild(child);

position += child.nodeSelfHeight();

@@ -602,7 +602,7 @@ Profiler.HeapSnapshotContainmentDataGrid = class extends Profiler.HeapSnapshotSo

sortingChanged() {

var rootNode = this.rootNode();

- if (rootNode.hasChildren)

+ if (rootNode.hasChildren())

rootNode.sort();

}

};