third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js - Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

index 9bf39dd3b4d06e8aaf9f41911ae3c53cbe959c03..b94e72605b67424b14a0f624b3bcf05e17875d58 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

@@ -135,7 +135,7 @@ Profiler.BottomUpProfileDataGridNode = class extends Profiler.ProfileDataGridNod

super.restore();

if (!this.children.length)

- this.hasChildren = this._willHaveChildren(this.profileNode);

+ this.setHasChildren(this._willHaveChildren(this.profileNode));

}

/**