Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2536553005: Add viewport with assumption that browser controls always show (Closed)

Created:
4 years ago by mdjones
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add viewport with assumption that browser controls always show This change adds a viewport and a new sizing flag to the layouts. Some layouts require the size of the screen to assume the browser controls are showing when they would otherwise not be. To use this viewport, a new sizing flag has been added to clearly identify its use: USE_PREVIOUS_TOOLBAR_STATE. As a result, this fixes a sizing bug in SimpleAnimationLayout. BUG=668643, 662427 Committed: https://crrev.com/fdf5564b291c19901f507ad181ad53cbfdac55d2 Cr-Commit-Position: refs/heads/master@{#435433}

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : fix bug on tablet #

Patch Set 4 : fix mock test class #

Messages

Total messages: 15 (8 generated)
mdjones
The sizing flags need to be more clear in general, but I can do that ...
4 years ago (2016-11-29 01:06:45 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years ago (2016-11-30 18:09:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536553005/40001
4 years ago (2016-11-30 19:40:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/172603)
4 years ago (2016-11-30 20:06:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536553005/60001
4 years ago (2016-11-30 21:22:32 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 21:56:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 21:59:13 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fdf5564b291c19901f507ad181ad53cbfdac55d2
Cr-Commit-Position: refs/heads/master@{#435433}

Powered by Google App Engine
This is Rietveld 408576698