chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java - Issue 2536553005: Add viewport with assumption that browser controls always show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

Issue 2536553005: Add viewport with assumption that browser controls always show (Closed)

Patch Set: fix mock test class Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockLayoutHost.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

index 76a34d7025bfab5680f2e706ec37e9f7ec193896..da377c74506316359bc7087fcc69e30bc1477a8a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

@@ -82,7 +82,7 @@ public class SimpleAnimationLayout

@Override

public int getSizingFlags() {

- return SizingFlags.HELPER_SUPPORTS_FULLSCREEN;

+ return SizingFlags.HELPER_SUPPORTS_FULLSCREEN | SizingFlags.USE_PREVIOUS_TOOLBAR_STATE;

}

@Override

@@ -418,7 +418,8 @@ public class SimpleAnimationLayout

super.updateSceneLayer(viewport, contentViewport, layerTitleCache, tabContentManager,

resourceManager, fullscreenManager);

assert mSceneLayer != null;

- mSceneLayer.pushLayers(getContext(), viewport, contentViewport, this, layerTitleCache,

- tabContentManager, resourceManager, fullscreenManager);

+ // The content viewport is intentionally sent as both params below.

+ mSceneLayer.pushLayers(getContext(), contentViewport, contentViewport, this,

+ layerTitleCache, tabContentManager, resourceManager, fullscreenManager);

}