chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java - Issue 2536553005: Add viewport with assumption that browser controls always show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

Issue 2536553005: Add viewport with assumption that browser controls always show (Closed)

Patch Set: fix mock test class Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerHost.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

index d1636d16f96786640573ab2b6f3029cc1ed73b77..4d03c47f65d8020223e4a3cb7d4e76c930655448 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

@@ -355,7 +355,8 @@ public class ToolbarSwipeLayout extends Layout implements Animatable<ToolbarSwip

super.updateSceneLayer(viewport, contentViewport, layerTitleCache, tabContentManager,

resourceManager, fullscreenManager);

assert mSceneLayer != null;

- mSceneLayer.pushLayers(getContext(), viewport, contentViewport, this, layerTitleCache,

- tabContentManager, resourceManager, fullscreenManager);

+ // contentViewport is intentionally passed for both parameters below.

+ mSceneLayer.pushLayers(getContext(), contentViewport, contentViewport, this,

+ layerTitleCache, tabContentManager, resourceManager, fullscreenManager);

}