Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

Issue 2536553005: Add viewport with assumption that browser controls always show (Closed)
Patch Set: fix mock test class Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
index 4828026c015462d989c8dfe5de7d3a7d6eb0a542..bb3fd3616a7fb9d5f65e057d7e3275d1e2f254ef 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
@@ -78,6 +78,9 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,
private int mFullscreenToken = FullscreenManager.INVALID_TOKEN;
private boolean mUpdateRequested;
+ // Whether or not the last layout was showing the browser controls.
+ private boolean mPreviousLayoutShowingToolbar;
+
// Used to store the visible viewport and not create a new Rect object every frame.
private final RectF mCachedVisibleViewport = new RectF();
private final RectF mCachedWindowViewport = new RectF();
@@ -318,6 +321,12 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,
final int flags = getActiveLayout().getSizingFlags();
if ((flags & SizingFlags.REQUIRE_FULLSCREEN_SIZE) != 0) {
mHost.getWindowViewport(rect);
+ } else if ((flags & SizingFlags.USE_PREVIOUS_TOOLBAR_STATE) != 0) {
+ if (mPreviousLayoutShowingToolbar) {
+ mHost.getViewportFullControls(rect);
+ } else {
+ mHost.getWindowViewport(rect);
+ }
} else {
mHost.getVisibleViewport(rect);
}
@@ -385,6 +394,8 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,
ChromeFullscreenManager fullscreenManager = mHost.getFullscreenManager();
if (fullscreenManager != null) {
+ mPreviousLayoutShowingToolbar = !fullscreenManager.areBrowserControlsOffScreen();
+
// Release any old fullscreen token we were holding.
fullscreenManager.getBrowserVisibilityDelegate().hideControlsPersistent(
mFullscreenToken);

Powered by Google App Engine
This is Rietveld 408576698