Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3081)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2536553005: Add viewport with assumption that browser controls always show (Closed)
Patch Set: fix mock test class Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 0b6b6ad602070ee521e044da6fdb51c578b94a44..fd3ce1dc0b963abbc9b80887bb37dbca6da1e37c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -531,17 +531,26 @@ public class CompositorViewHolder extends CoordinatorLayout
@Override
public void getVisibleViewport(RectF outRect) {
- // All of these values are in pixels.
- float viewportTop = 0;
+ getWindowViewport(outRect);
+
float bottomControlOffset = 0;
if (mFullscreenManager != null) {
- viewportTop = mFullscreenManager.getTopVisibleContentOffset();
+ // All of these values are in pixels.
+ outRect.top += mFullscreenManager.getTopVisibleContentOffset();
bottomControlOffset = mFullscreenManager.getBottomControlOffset();
}
- float viewportBottom =
- getHeight() - (getBottomControlsHeightPixels() - bottomControlOffset);
+ outRect.bottom -= (getBottomControlsHeightPixels() - bottomControlOffset);
+ }
+
+ @Override
+ public void getViewportFullControls(RectF outRect) {
+ getWindowViewport(outRect);
- outRect.set(0, viewportTop, getWidth(), viewportBottom);
+ if (mFullscreenManager != null) {
+ // All of these values are in pixels.
+ outRect.top += mFullscreenManager.getTopControlsHeight();
+ outRect.bottom -= mFullscreenManager.getBottomControlsHeight();
+ }
}
@Override
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698