Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2536323003: [LayoutNG] Fix enum values to conform to kEnumName in style guide. (Closed)

Created:
4 years ago by ikilpatrick
Modified:
4 years ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Fix enum values to conform to kEnumName in style guide. Committed: https://crrev.com/9ee2d8c86e00e738f43cac22115a08c71876e4e8 Cr-Commit-Position: refs/heads/master@{#435526}

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -203 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 8 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_writing_mode.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ikilpatrick
4 years ago (2016-11-30 21:32:52 UTC) #2
cbiesinger
That doesn't seem consistent with https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Naming?
4 years ago (2016-11-30 21:42:51 UTC) #3
cbiesinger
Ah, but it is consistent with https://www.chromium.org/blink/coding-style Which one do we follow...?
4 years ago (2016-11-30 21:43:37 UTC) #4
cbiesinger1
Lgtm
4 years ago (2016-11-30 22:07:08 UTC) #5
cbiesinger1
On 2016/11/30 22:07:08, cbiesinger1 wrote: > Lgtm (Per https://docs.google.com/document/d/1ZQLiQKw9hCOyDDhDS4JhckhuiJmLqSbw9FLfySMyxgU/edit#heading=h.70rw9u3vmpim and https://groups.google.com/a/chromium.org/forum/m/?utm_medium=email&utm_source=footer#!msg/platform-architecture-dev/JOY3TKxQDhE/7R2W_KRgBQAJ the k style is ...
4 years ago (2016-11-30 22:07:53 UTC) #6
atotic
On 2016/11/30 at 21:32:52, ikilpatrick wrote: > glad you are doing this.
4 years ago (2016-11-30 22:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536323003/20001
4 years ago (2016-11-30 23:51:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 02:03:28 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 02:07:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ee2d8c86e00e738f43cac22115a08c71876e4e8
Cr-Commit-Position: refs/heads/master@{#435526}

Powered by Google App Engine
This is Rietveld 408576698