Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2536323003: [LayoutNG] Fix enum values to conform to kEnumName in style guide. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index d2c8d5a26a340670f1f816e74da97edff59de64a..3a652003e292bdf5574ecff367ac127a034c5fca 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -23,13 +23,13 @@
namespace blink {
NGBlockNode::NGBlockNode(LayoutObject* layout_object)
- : NGLayoutInputNode(NGLayoutInputNodeType::LegacyBlock),
+ : NGLayoutInputNode(NGLayoutInputNodeType::kLegacyBlock),
layout_box_(toLayoutBox(layout_object)) {
DCHECK(layout_box_);
}
NGBlockNode::NGBlockNode(ComputedStyle* style)
- : NGLayoutInputNode(NGLayoutInputNodeType::LegacyBlock),
+ : NGLayoutInputNode(NGLayoutInputNodeType::kLegacyBlock),
layout_box_(nullptr),
style_(style) {
DCHECK(style_);
@@ -110,11 +110,11 @@ bool NGBlockNode::ComputeMinAndMaxContentSizes(MinAndMaxContentSizes* sizes) {
// TODO(cbiesinger): For orthogonal children, we need to always synthesize.
NGLayoutAlgorithm::MinAndMaxState state =
minmax_algorithm_->ComputeMinAndMaxContentSizes(sizes);
- if (state == NGLayoutAlgorithm::Success)
+ if (state == NGLayoutAlgorithm::kSuccess)
return true;
- if (state == NGLayoutAlgorithm::Pending)
+ if (state == NGLayoutAlgorithm::kPending)
return false;
- DCHECK_EQ(state, NGLayoutAlgorithm::NotImplemented);
+ DCHECK_EQ(state, NGLayoutAlgorithm::kNotImplemented);
// TODO(cbiesinger): Replace the loops below with a state machine like in
// Layout.
@@ -309,7 +309,7 @@ NGPhysicalFragment* NGBlockNode::RunOldLayout(
LayoutRect overflow = layout_box_->layoutOverflowRect();
// TODO(layout-ng): This does not handle writing modes correctly (for
// overflow)
- NGFragmentBuilder builder(NGPhysicalFragmentBase::FragmentBox);
+ NGFragmentBuilder builder(NGPhysicalFragmentBase::kFragmentBox);
builder.SetInlineSize(layout_box_->logicalWidth())
.SetBlockSize(layout_box_->logicalHeight())
.SetDirection(layout_box_->styleRef().direction())

Powered by Google App Engine
This is Rietveld 408576698