Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_units_test.cc

Issue 2536323003: [LayoutNG] Fix enum values to conform to kEnumName in style guide. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_units.h" 5 #include "core/layout/ng/ng_units.h"
6 6
7 #include "platform/text/TextDirection.h" 7 #include "platform/text/TextDirection.h"
8 #include "core/layout/ng/ng_writing_mode.h" 8 #include "core/layout/ng/ng_writing_mode.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 namespace { 13 namespace {
14 14
15 TEST(NGUnitsTest, ConvertLogicalOffsetToPhysicalOffset) { 15 TEST(NGUnitsTest, ConvertLogicalOffsetToPhysicalOffset) {
16 NGLogicalOffset logical_offset(LayoutUnit(20), LayoutUnit(30)); 16 NGLogicalOffset logical_offset(LayoutUnit(20), LayoutUnit(30));
17 NGPhysicalSize outer_size(LayoutUnit(300), LayoutUnit(400)); 17 NGPhysicalSize outer_size(LayoutUnit(300), LayoutUnit(400));
18 NGPhysicalSize inner_size(LayoutUnit(5), LayoutUnit(65)); 18 NGPhysicalSize inner_size(LayoutUnit(5), LayoutUnit(65));
19 NGPhysicalOffset offset; 19 NGPhysicalOffset offset;
20 20
21 offset = logical_offset.ConvertToPhysical(HorizontalTopBottom, LTR, 21 offset = logical_offset.ConvertToPhysical(kHorizontalTopBottom, LTR,
22 outer_size, inner_size); 22 outer_size, inner_size);
23 EXPECT_EQ(LayoutUnit(20), offset.left); 23 EXPECT_EQ(LayoutUnit(20), offset.left);
24 EXPECT_EQ(LayoutUnit(30), offset.top); 24 EXPECT_EQ(LayoutUnit(30), offset.top);
25 25
26 offset = logical_offset.ConvertToPhysical(HorizontalTopBottom, RTL, 26 offset = logical_offset.ConvertToPhysical(kHorizontalTopBottom, RTL,
27 outer_size, inner_size); 27 outer_size, inner_size);
28 EXPECT_EQ(LayoutUnit(275), offset.left); 28 EXPECT_EQ(LayoutUnit(275), offset.left);
29 EXPECT_EQ(LayoutUnit(30), offset.top); 29 EXPECT_EQ(LayoutUnit(30), offset.top);
30 30
31 offset = logical_offset.ConvertToPhysical(VerticalRightLeft, LTR, outer_size, 31 offset = logical_offset.ConvertToPhysical(kVerticalRightLeft, LTR, outer_size,
32 inner_size); 32 inner_size);
33 EXPECT_EQ(LayoutUnit(265), offset.left); 33 EXPECT_EQ(LayoutUnit(265), offset.left);
34 EXPECT_EQ(LayoutUnit(20), offset.top); 34 EXPECT_EQ(LayoutUnit(20), offset.top);
35 35
36 offset = logical_offset.ConvertToPhysical(VerticalRightLeft, RTL, outer_size, 36 offset = logical_offset.ConvertToPhysical(kVerticalRightLeft, RTL, outer_size,
37 inner_size); 37 inner_size);
38 EXPECT_EQ(LayoutUnit(265), offset.left); 38 EXPECT_EQ(LayoutUnit(265), offset.left);
39 EXPECT_EQ(LayoutUnit(315), offset.top); 39 EXPECT_EQ(LayoutUnit(315), offset.top);
40 40
41 offset = logical_offset.ConvertToPhysical(SidewaysRightLeft, LTR, outer_size, 41 offset = logical_offset.ConvertToPhysical(kSidewaysRightLeft, LTR, outer_size,
42 inner_size); 42 inner_size);
43 EXPECT_EQ(LayoutUnit(265), offset.left); 43 EXPECT_EQ(LayoutUnit(265), offset.left);
44 EXPECT_EQ(LayoutUnit(20), offset.top); 44 EXPECT_EQ(LayoutUnit(20), offset.top);
45 45
46 offset = logical_offset.ConvertToPhysical(SidewaysRightLeft, RTL, outer_size, 46 offset = logical_offset.ConvertToPhysical(kSidewaysRightLeft, RTL, outer_size,
47 inner_size); 47 inner_size);
48 EXPECT_EQ(LayoutUnit(265), offset.left); 48 EXPECT_EQ(LayoutUnit(265), offset.left);
49 EXPECT_EQ(LayoutUnit(315), offset.top); 49 EXPECT_EQ(LayoutUnit(315), offset.top);
50 50
51 offset = logical_offset.ConvertToPhysical(VerticalLeftRight, LTR, outer_size, 51 offset = logical_offset.ConvertToPhysical(kVerticalLeftRight, LTR, outer_size,
52 inner_size); 52 inner_size);
53 EXPECT_EQ(LayoutUnit(30), offset.left); 53 EXPECT_EQ(LayoutUnit(30), offset.left);
54 EXPECT_EQ(LayoutUnit(20), offset.top); 54 EXPECT_EQ(LayoutUnit(20), offset.top);
55 55
56 offset = logical_offset.ConvertToPhysical(VerticalLeftRight, RTL, outer_size, 56 offset = logical_offset.ConvertToPhysical(kVerticalLeftRight, RTL, outer_size,
57 inner_size); 57 inner_size);
58 EXPECT_EQ(LayoutUnit(30), offset.left); 58 EXPECT_EQ(LayoutUnit(30), offset.left);
59 EXPECT_EQ(LayoutUnit(315), offset.top); 59 EXPECT_EQ(LayoutUnit(315), offset.top);
60 60
61 offset = logical_offset.ConvertToPhysical(SidewaysLeftRight, LTR, outer_size, 61 offset = logical_offset.ConvertToPhysical(kSidewaysLeftRight, LTR, outer_size,
62 inner_size); 62 inner_size);
63 EXPECT_EQ(LayoutUnit(30), offset.left); 63 EXPECT_EQ(LayoutUnit(30), offset.left);
64 EXPECT_EQ(LayoutUnit(315), offset.top); 64 EXPECT_EQ(LayoutUnit(315), offset.top);
65 65
66 offset = logical_offset.ConvertToPhysical(SidewaysLeftRight, RTL, outer_size, 66 offset = logical_offset.ConvertToPhysical(kSidewaysLeftRight, RTL, outer_size,
67 inner_size); 67 inner_size);
68 EXPECT_EQ(LayoutUnit(30), offset.left); 68 EXPECT_EQ(LayoutUnit(30), offset.left);
69 EXPECT_EQ(LayoutUnit(20), offset.top); 69 EXPECT_EQ(LayoutUnit(20), offset.top);
70 } 70 }
71 71
72 // Ideally, this would be tested by NGBoxStrut::ConvertToPhysical, but 72 // Ideally, this would be tested by NGBoxStrut::ConvertToPhysical, but
73 // this has not been implemented yet. 73 // this has not been implemented yet.
74 TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) { 74 TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) {
75 LayoutUnit left{5}, right{10}, top{15}, bottom{20}; 75 LayoutUnit left{5}, right{10}, top{15}, bottom{20};
76 NGPhysicalBoxStrut physical{left, right, top, bottom}; 76 NGPhysicalBoxStrut physical{left, right, top, bottom};
77 77
78 NGBoxStrut logical = physical.ConvertToLogical(HorizontalTopBottom, LTR); 78 NGBoxStrut logical = physical.ConvertToLogical(kHorizontalTopBottom, LTR);
79 EXPECT_EQ(left, logical.inline_start); 79 EXPECT_EQ(left, logical.inline_start);
80 EXPECT_EQ(top, logical.block_start); 80 EXPECT_EQ(top, logical.block_start);
81 81
82 logical = physical.ConvertToLogical(HorizontalTopBottom, RTL); 82 logical = physical.ConvertToLogical(kHorizontalTopBottom, RTL);
83 EXPECT_EQ(right, logical.inline_start); 83 EXPECT_EQ(right, logical.inline_start);
84 EXPECT_EQ(top, logical.block_start); 84 EXPECT_EQ(top, logical.block_start);
85 85
86 logical = physical.ConvertToLogical(VerticalLeftRight, LTR); 86 logical = physical.ConvertToLogical(kVerticalLeftRight, LTR);
87 EXPECT_EQ(top, logical.inline_start); 87 EXPECT_EQ(top, logical.inline_start);
88 EXPECT_EQ(left, logical.block_start); 88 EXPECT_EQ(left, logical.block_start);
89 89
90 logical = physical.ConvertToLogical(VerticalLeftRight, RTL); 90 logical = physical.ConvertToLogical(kVerticalLeftRight, RTL);
91 EXPECT_EQ(bottom, logical.inline_start); 91 EXPECT_EQ(bottom, logical.inline_start);
92 EXPECT_EQ(left, logical.block_start); 92 EXPECT_EQ(left, logical.block_start);
93 93
94 logical = physical.ConvertToLogical(VerticalRightLeft, LTR); 94 logical = physical.ConvertToLogical(kVerticalRightLeft, LTR);
95 EXPECT_EQ(top, logical.inline_start); 95 EXPECT_EQ(top, logical.inline_start);
96 EXPECT_EQ(right, logical.block_start); 96 EXPECT_EQ(right, logical.block_start);
97 97
98 logical = physical.ConvertToLogical(VerticalRightLeft, RTL); 98 logical = physical.ConvertToLogical(kVerticalRightLeft, RTL);
99 EXPECT_EQ(bottom, logical.inline_start); 99 EXPECT_EQ(bottom, logical.inline_start);
100 EXPECT_EQ(right, logical.block_start); 100 EXPECT_EQ(right, logical.block_start);
101 } 101 }
102 102
103 TEST(NGUnitsTest, ShrinkToFit) { 103 TEST(NGUnitsTest, ShrinkToFit) {
104 MinAndMaxContentSizes sizes; 104 MinAndMaxContentSizes sizes;
105 105
106 sizes.min_content = LayoutUnit(100); 106 sizes.min_content = LayoutUnit(100);
107 sizes.max_content = LayoutUnit(200); 107 sizes.max_content = LayoutUnit(200);
108 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(300))); 108 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(300)));
109 109
110 sizes.min_content = LayoutUnit(100); 110 sizes.min_content = LayoutUnit(100);
111 sizes.max_content = LayoutUnit(300); 111 sizes.max_content = LayoutUnit(300);
112 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(200))); 112 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(200)));
113 113
114 sizes.min_content = LayoutUnit(200); 114 sizes.min_content = LayoutUnit(200);
115 sizes.max_content = LayoutUnit(300); 115 sizes.max_content = LayoutUnit(300);
116 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(100))); 116 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(100)));
117 } 117 }
118 118
119 } // namespace 119 } // namespace
120 120
121 } // namespace blink 121 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_units.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_writing_mode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698