Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2536323003: [LayoutNG] Fix enum values to conform to kEnumName in style guide. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
index 0aae7a2495f8e11c81afdb0a10d631dadd4cdfa9..f886a2951c332719281328db86467a8e4486901c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
@@ -10,7 +10,7 @@ namespace blink {
NGFragmentBuilder::NGFragmentBuilder(
NGPhysicalFragmentBase::NGFragmentType type)
- : type_(type), writing_mode_(HorizontalTopBottom), direction_(LTR) {}
+ : type_(type), writing_mode_(kHorizontalTopBottom), direction_(LTR) {}
NGFragmentBuilder& NGFragmentBuilder::SetWritingMode(
NGWritingMode writing_mode) {
@@ -45,7 +45,7 @@ NGFragmentBuilder& NGFragmentBuilder::SetBlockOverflow(LayoutUnit size) {
NGFragmentBuilder& NGFragmentBuilder::AddChild(NGFragmentBase* child,
NGLogicalOffset offset) {
- DCHECK_EQ(type_, NGPhysicalFragmentBase::FragmentBox)
+ DCHECK_EQ(type_, NGPhysicalFragmentBase::kFragmentBox)
<< "Only box fragments can have children";
children_.append(child->PhysicalFragment());
offsets_.append(offset);
@@ -68,7 +68,7 @@ NGFragmentBuilder& NGFragmentBuilder::SetMarginStrutBlockEnd(
NGPhysicalFragment* NGFragmentBuilder::ToFragment() {
// TODO(layout-ng): Support text fragments
- DCHECK_EQ(type_, NGPhysicalFragmentBase::FragmentBox);
+ DCHECK_EQ(type_, NGPhysicalFragmentBase::kFragmentBox);
DCHECK_EQ(offsets_.size(), children_.size());
NGPhysicalSize physical_size = size_.ConvertToPhysical(writing_mode_);

Powered by Google App Engine
This is Rietveld 408576698