first-paint and first-contentful paint

first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2528513003
Cr-Commit-Position: refs/heads/master@{#443142}
Committed: https://chromium.googlesource.com/chromium/src/+/20d9207c7997b8d0d2a978032e25a3a4274a9f5f

[sunjian, 2016-11-23 22:04:25]

Description was changed from

==========
first-paint and first-contentful paint

BUG=
==========

to

==========
first-paint and first-contentful paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sunjian, 2016-11-23 22:22:58]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 22:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2016-11-23 22:25:55]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2016-11-23 22:27:01]

Patchset #1 (id:1) has been deleted

[sunjian, 2016-11-23 22:39:21]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 22:40:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 22:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 22:44:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunjian, 2016-11-28 19:05:31]

Patchset #1 (id:20001) has been deleted

[sunjian, 2016-11-28 19:24:23]

Patchset #1 (id:40001) has been deleted

[sunjian, 2016-11-28 19:25:41]

Description was changed from

==========
first-paint and first-contentful paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
first-paint and first-contentful paint

BUG=
==========

[sunjian, 2016-11-28 19:25:42]

sunjian@chromium.org changed reviewers:
+ panicker@chromium.org, yoav@yoav.ws

[panicker, 2016-11-28 21:32:26]

panicker@chromium.org changed reviewers:
- yoav@yoav.ws

[panicker, 2016-11-28 21:32:27]

-Yoav for now: we are still iterating here.

[panicker, 2016-11-29 22:21:15]

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.h:153:
PerformancePaintTimingEntries m_paintTimingBuffer;
This is not supposed to be buffer-able yet due to a spec limitation.
Let's remove the buffer, and could add it back in the future when the spec
supports it.
(This simplifies the implementation a lot)

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformancePaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformancePaintTiming.cpp:29: void
PerformancePaintTiming::buildJSONValue(V8ObjectBuilder& builder) const {
no need to override this ?

[panicker, 2016-11-29 23:49:19]

panicker@chromium.org changed reviewers:
+ tdresser@chromium.org

[panicker, 2016-11-29 23:49:20]

+Tim

[tdresser, 2016-11-30 17:41:56]

Sounds like removing the buffer will simplify this a bunch - I'll take a look
once the buffer has been removed, and we've ideally got some tests in place.

[sunjian, 2016-12-01 00:12:21]

Description was changed from

==========
first-paint and first-contentful paint

BUG=
==========

to

==========
first-paint and first-contentful paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sunjian, 2016-12-01 00:13:23]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 00:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:44:52]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sunjian, 2016-12-02 21:38:15]

Patchset #4 (id:120001) has been deleted

[sunjian, 2016-12-02 21:39:57]

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.h (right):

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.h:153:
PerformancePaintTimingEntries m_paintTimingBuffer;
On 2016/11/29 22:21:15, Shubhie wrote:
> This is not supposed to be buffer-able yet due to a spec limitation.
> Let's remove the buffer, and could add it back in the future when the spec
> supports it.
> (This simplifies the implementation a lot)

Done.

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformancePaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformancePaintTiming.cpp:29: void
PerformancePaintTiming::buildJSONValue(V8ObjectBuilder& builder) const {
On 2016/11/29 22:21:15, Shubhie wrote:
> no need to override this ?

Done.

[sunjian, 2016-12-02 21:40:19]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 21:41:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 21:45:42]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[panicker, 2016-12-05 20:51:23]

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/performance/performance-first-paint-timing-observable.html
(right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/performance/performance-first-paint-timing-observable.html:14:
var entries = entryList.getEntries();
Add comment indicating why FP is present and FCP is not

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.cpp:12: #include
"core/timing/PerformancePaintTiming.h"
would be nice to avoid this dep directly on PerformancePaintTiming.
maybe add 2 methods: addFirstPaintTiming & addFirstContentfulPaintTiming in
PerformanceBase, and then map to the enum there.

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:106: case
PerformanceEntry::Paint:
Nit: add another comment here instead of adding to list below.

[sunjian, 2016-12-07 21:55:40]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[sunjian, 2016-12-07 21:55:44]

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/performance/performance-first-paint-timing-observable.html
(right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/performance/performance-first-paint-timing-observable.html:14:
var entries = entryList.getEntries();
On 2016/12/05 20:51:23, panicker wrote:
> Add comment indicating why FP is present and FCP is not

Done.

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.cpp:12: #include
"core/timing/PerformancePaintTiming.h"
On 2016/12/05 20:51:23, panicker wrote:
> would be nice to avoid this dep directly on PerformancePaintTiming.
> maybe add 2 methods: addFirstPaintTiming & addFirstContentfulPaintTiming in
> PerformanceBase, and then map to the enum there.

Done.

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2528513003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:106: case
PerformanceEntry::Paint:
On 2016/12/05 20:51:23, panicker wrote:
> Nit: add another comment here instead of adding to list below.

Done.

[commit-bot: I haz the power, 2016-12-07 21:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:24:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tdresser, 2016-12-08 14:54:40]

LGTM with nit.

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html
(right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html:15:
assert_equals(entries.length, 2,
Does the spec require that these are dispatched at the same time? We should
write this test such that it should be easy to upstream.

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.h (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.h:10: #include
"core/timing/PerformancePaintTiming.h"
Is this needed?

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformancePaintTiming.idl (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformancePaintTiming.idl:5: //
https://github.com/tdresser/time-to-first-paint
Update to WICG address.

[tdresser, 2016-12-08 14:55:00]

Can you fill in the BUG section of the CL description?

[sunjian, 2016-12-08 23:57:37]

Description was changed from

==========
first-paint and first-contentful paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
first-paint and first-contentful paint

BUG=657825
==========

[panicker, 2016-12-09 00:15:01]

LGTM

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html
(right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html:15:
assert_equals(entries.length, 2,
On 2016/12/08 14:54:40, tdresser wrote:
> Does the spec require that these are dispatched at the same time? We should
> write this test such that it should be easy to upstream.

I would like to spec this so it's dispatched as it occurs (PerformanceObserver
itself doesn't guarantee immediate delivery).
That way if there's an abort in between, one could know that the page reached FP
atleast.

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.h (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.h:10: #include
"core/timing/PerformancePaintTiming.h"
On 2016/12/08 14:54:40, tdresser wrote:
> Is this needed?

Revert this file? The idea was to remove this dep.

[panicker, 2016-12-09 00:20:36]

panicker@chromium.org changed reviewers:
+ haraken@chromium.org

[panicker, 2016-12-09 00:20:37]

Kentaro, could you review for OWNERs?

[haraken, 2016-12-09 00:30:03]

LGTM

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.cpp:24: performance =
DOMWindowPerformance::performance(*frame->localDOMWindow());

frame->localDOMWindow() may return null. Check it.

[sunjian, 2016-12-09 01:54:53]

Description was changed from

==========
first-paint and first-contentful paint

BUG=657825
==========

to

==========
first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sunjian, 2016-12-09 01:55:01]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 01:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 02:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 02:44:08]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sunjian, 2016-12-09 19:06:50]

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.cpp (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.cpp:24: performance =
DOMWindowPerformance::performance(*frame->localDOMWindow());
On 2016/12/09 00:30:03, haraken wrote:
> 
> frame->localDOMWindow() may return null. Check it.
> 

Done.

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintTiming.h (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintTiming.h:10: #include
"core/timing/PerformancePaintTiming.h"
On 2016/12/08 14:54:40, tdresser wrote:
> Is this needed?

Done.

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformancePaintTiming.idl (right):

https://codereview.chromium.org/2528513003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformancePaintTiming.idl:5: //
https://github.com/tdresser/time-to-first-paint
On 2016/12/08 14:54:40, tdresser wrote:
> Update to WICG address.

Done.

[sunjian, 2016-12-09 20:13:23]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 20:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2016-12-09 20:33:53]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2016-12-09 20:34:00]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 20:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 21:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 21:00:40]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2016-12-09 21:31:53]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2016-12-09 21:31:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps200001
(title: "moved paint events after observer script to make sure observing happens
before paint events get tri…")

[commit-bot: I haz the power, 2016-12-09 21:33:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 22:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 22:12:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sunjian, 2016-12-09 23:12:55]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 23:13:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:16:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:16:02]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sunjian, 2016-12-10 02:16:36]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2016-12-10 02:16:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps240001
(title: "editted expected.txt")

[commit-bot: I haz the power, 2016-12-10 02:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 04:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 04:11:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2017-01-04 22:57:02]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 22:57:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 00:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 00:46:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunjian, 2017-01-05 00:56:59]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-05 00:56:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps260001
(title: "fixed cross-origin-object layout test failure")

[commit-bot: I haz the power, 2017-01-05 00:57:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 02:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:44:44]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-05 18:23:07]

The CQ bit was checked by sunjian@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:23:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 19:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:40:04]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-06 01:29:12]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:15:06]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-06 20:31:24]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-06 20:31:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps300001
(title: "merged with master")

[commit-bot: I haz the power, 2017-01-06 20:31:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:32:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:32:38]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-06 22:46:05]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-06 22:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps320001
(title: "updated PerformanceEntryType size")

[commit-bot: I haz the power, 2017-01-06 22:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2017-01-06 23:47:47]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2017-01-06 23:48:40]

Made some changes after LGTMed. Merged conflicts and had to make changes to the
size of the PerformanceEntryType.

[panicker, 2017-01-06 23:55:31]

https://codereview.chromium.org/2528513003/diff/320001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformanceEntry.h (right):

https://codereview.chromium.org/2528513003/diff/320001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformanceEntry.h:46: using
PerformanceEntryType = unsigned short;
prefer unsigned long so we don't have to worry about this for upto 32 types (vs.
16)

[sunjian, 2017-01-07 00:19:34]

https://codereview.chromium.org/2528513003/diff/320001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/timing/PerformanceEntry.h (right):

https://codereview.chromium.org/2528513003/diff/320001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/timing/PerformanceEntry.h:46: using
PerformanceEntryType = unsigned short;
On 2017/01/06 23:55:31, panicker wrote:
> prefer unsigned long so we don't have to worry about this for upto 32 types
(vs.
> 16) 

Done.

[panicker, 2017-01-07 00:23:52]

LGTM

[sunjian, 2017-01-07 01:02:00]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-07 01:02:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps340001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-07 01:02:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 01:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 01:51:57]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-09 18:38:07]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-09 18:38:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps360001
(title: "sync")

[commit-bot: I haz the power, 2017-01-09 18:38:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:23:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2017-01-09 21:36:09]

The CQ bit was checked by sunjian@chromium.org

[commit-bot: I haz the power, 2017-01-09 21:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2017-01-09 22:19:02]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 22:19:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2017-01-09 22:20:03]

Patchset #16 (id:380001) has been deleted

[commit-bot: I haz the power, 2017-01-09 22:21:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[commit-bot: I haz the power, 2017-01-09 22:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:42:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sunjian, 2017-01-09 23:26:04]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[sunjian, 2017-01-09 23:26:19]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2017-01-09 23:32:54]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[sunjian, 2017-01-09 23:32:57]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2017-01-09 23:33:11]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 23:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:28:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2017-01-10 03:11:39]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-10 03:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps420001
(title: "cross-origin object failure")

[commit-bot: I haz the power, 2017-01-10 03:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 07:13:36]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[sunjian, 2017-01-10 19:22:04]

Patchset #17 (id:420001) has been deleted

[sunjian, 2017-01-10 19:22:48]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-10 19:22:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps440001
(title: "addressed cross-origin object failure")

[commit-bot: I haz the power, 2017-01-10 19:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:24:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:24:38]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[panicker, 2017-01-10 20:39:21]

On 2017/01/10 20:24:38, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

This appears to be a real issue with the new paint tests failing for
linux_layout_tests_slimming_paint_v2.
We need to dig into this, I'll try to dig up some pointers. Tim - any tips are
appreciated.

[tdresser, 2017-01-11 14:15:22]

On 2017/01/10 20:39:21, panicker wrote:
> On 2017/01/10 20:24:38, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
> > (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
> 
> This appears to be a real issue with the new paint tests failing for
> linux_layout_tests_slimming_paint_v2.
> We need to dig into this, I'll try to dig up some pointers. Tim - any tips are
> appreciated.

Other than reaching out to chrishtr@, I don't have any concrete advice.

[Xianzhu, 2017-01-11 19:18:38]

You can unblock this CL from the fix of first paint tracking for spv2
(https://codereview.chromium.org/2623043002/) by adding the failure expectation
in LayoutTests/FlagExpectations/enable-slimming-paint-v2:

crbug.com/657825 fast/performance/performance-first-paint-timing-observable.html
[ Skip ]
crbug.com/657825 fast/performance/performance-paint-timing-observable.html [
Skip ]

Then you can land this CL.

I will remove the above expectations in
https://codereview.chromium.org/2623043002/.

[Xianzhu, 2017-01-11 19:19:14]

On 2017/01/11 19:18:38, Xianzhu wrote:
> You can unblock this CL from the fix of first paint tracking for spv2
> (https://codereview.chromium.org/2623043002/) by adding the failure
expectation

s/adding the failure expectation/skipping the tests for spv2/

> in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
> 
> crbug.com/657825
fast/performance/performance-first-paint-timing-observable.html
> [ Skip ]
> crbug.com/657825 fast/performance/performance-paint-timing-observable.html [
> Skip ]
> 
> Then you can land this CL.
> 
> I will remove the above expectations in
> https://codereview.chromium.org/2623043002/.

[sunjian, 2017-01-11 20:17:39]

I added crbug.com/657825 fast/performance/performance-
first-paint-timing-observable.html [ Skip ] crbug.com/657825
 fast/performance/performance-paint-timing-observable.html [ Skip ]. The
test still failed when i ran python
third_party/WebKit/Tools/Scripts/run-webkit-tests -t Release
--additional-driver-flag=--enable-slimming-paint-v2
fast/performance/performance-first-paint-timing-observable.html. It shows
that it's running one test instead of skipping it. Did i miss anything?

Jian

On Wed, Jan 11, 2017 at 11:19 AM, <wangxianzhu@chromium.org> wrote:

> On 2017/01/11 19:18:38, Xianzhu wrote:
> > You can unblock this CL from the fix of first paint tracking for spv2
> > (https://codereview.chromium.org/2623043002/) by adding the failure
> expectation
>
> s/adding the failure expectation/skipping the tests for spv2/
>
> > in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
> >
> > crbug.com/657825
> fast/performance/performance-first-paint-timing-observable.html
> > [ Skip ]
> > crbug.com/657825 fast/performance/performance-paint-timing-observable.html
> [
> > Skip ]
> >
> > Then you can land this CL.
> >
> > I will remove the above expectations in
> > https://codereview.chromium.org/2623043002/.
>
>
>
> https://codereview.chromium.org/2528513003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[sunjian, 2017-01-11 20:17:39]

I added crbug.com/657825 fast/performance/performance-
first-paint-timing-observable.html [ Skip ] crbug.com/657825
 fast/performance/performance-paint-timing-observable.html [ Skip ]. The
test still failed when i ran python
third_party/WebKit/Tools/Scripts/run-webkit-tests -t Release
--additional-driver-flag=--enable-slimming-paint-v2
fast/performance/performance-first-paint-timing-observable.html. It shows
that it's running one test instead of skipping it. Did i miss anything?

Jian

On Wed, Jan 11, 2017 at 11:19 AM, <wangxianzhu@chromium.org> wrote:

> On 2017/01/11 19:18:38, Xianzhu wrote:
> > You can unblock this CL from the fix of first paint tracking for spv2
> > (https://codereview.chromium.org/2623043002/) by adding the failure
> expectation
>
> s/adding the failure expectation/skipping the tests for spv2/
>
> > in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
> >
> > crbug.com/657825
> fast/performance/performance-first-paint-timing-observable.html
> > [ Skip ]
> > crbug.com/657825 fast/performance/performance-paint-timing-observable.html
> [
> > Skip ]
> >
> > Then you can land this CL.
> >
> > I will remove the above expectations in
> > https://codereview.chromium.org/2623043002/.
>
>
>
> https://codereview.chromium.org/2528513003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2017-01-11 20:48:36]

Can you try re-running using the trybot?

On Wed, Jan 11, 2017 at 12:17 PM, Jian Sun <sunjian@chromium.org> wrote:

> I added crbug.com/657825 fast/performance/performance-first-
> paint-timing-observable.html [ Skip ] crbug.com/657825 fast/
> performance/performance-paint-timing-observable.html [ Skip ]. The test
> still failed when i ran python
third_party/WebKit/Tools/Scripts/run-webkit-tests
> -t Release --additional-driver-flag=--enable-slimming-paint-v2
> fast/performance/performance-first-paint-timing-observable.html. It shows
> that it's running one test instead of skipping it. Did i miss anything?
>
> Jian
>
> On Wed, Jan 11, 2017 at 11:19 AM, <wangxianzhu@chromium.org> wrote:
>
>> On 2017/01/11 19:18:38, Xianzhu wrote:
>> > You can unblock this CL from the fix of first paint tracking for spv2
>> > (https://codereview.chromium.org/2623043002/) by adding the failure
>> expectation
>>
>> s/adding the failure expectation/skipping the tests for spv2/
>>
>> > in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
>> >
>> > crbug.com/657825
>> fast/performance/performance-first-paint-timing-observable.html
>> > [ Skip ]
>> > crbug.com/657825 fast/performance/performance-paint-timing-observable.html
>> [
>> > Skip ]
>> >
>> > Then you can land this CL.
>> >
>> > I will remove the above expectations in
>> > https://codereview.chromium.org/2623043002/.
>>
>>
>>
>> https://codereview.chromium.org/2528513003/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-01-11 20:48:36]

Can you try re-running using the trybot?

On Wed, Jan 11, 2017 at 12:17 PM, Jian Sun <sunjian@chromium.org> wrote:

> I added crbug.com/657825 fast/performance/performance-first-
> paint-timing-observable.html [ Skip ] crbug.com/657825 fast/
> performance/performance-paint-timing-observable.html [ Skip ]. The test
> still failed when i ran python
third_party/WebKit/Tools/Scripts/run-webkit-tests
> -t Release --additional-driver-flag=--enable-slimming-paint-v2
> fast/performance/performance-first-paint-timing-observable.html. It shows
> that it's running one test instead of skipping it. Did i miss anything?
>
> Jian
>
> On Wed, Jan 11, 2017 at 11:19 AM, <wangxianzhu@chromium.org> wrote:
>
>> On 2017/01/11 19:18:38, Xianzhu wrote:
>> > You can unblock this CL from the fix of first paint tracking for spv2
>> > (https://codereview.chromium.org/2623043002/) by adding the failure
>> expectation
>>
>> s/adding the failure expectation/skipping the tests for spv2/
>>
>> > in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
>> >
>> > crbug.com/657825
>> fast/performance/performance-first-paint-timing-observable.html
>> > [ Skip ]
>> > crbug.com/657825 fast/performance/performance-paint-timing-observable.html
>> [
>> > Skip ]
>> >
>> > Then you can land this CL.
>> >
>> > I will remove the above expectations in
>> > https://codereview.chromium.org/2623043002/.
>>
>>
>>
>> https://codereview.chromium.org/2528513003/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sunjian, 2017-01-11 20:56:29]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:57:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-11 22:17:13]

On 2017/01/11 20:17:39, sunjian wrote:
> I added crbug.com/657825 fast/performance/performance-
> first-paint-timing-observable.html [ Skip ] crbug.com/657825
>  fast/performance/performance-paint-timing-observable.html [ Skip ]. The
> test still failed when i ran python
> third_party/WebKit/Tools/Scripts/run-webkit-tests -t Release
> --additional-driver-flag=--enable-slimming-paint-v2
> fast/performance/performance-first-paint-timing-observable.html. It shows
> that it's running one test instead of skipping it. Did i miss anything?
>

This is nothing wrong :)

run-webkit-tests will run skipped tests if the tests are explicitly listed in
the command line.

> Jian
> 
> On Wed, Jan 11, 2017 at 11:19 AM, <mailto:wangxianzhu@chromium.org> wrote:
> 
> > On 2017/01/11 19:18:38, Xianzhu wrote:
> > > You can unblock this CL from the fix of first paint tracking for spv2
> > > (https://codereview.chromium.org/2623043002/) by adding the failure
> > expectation
> >
> > s/adding the failure expectation/skipping the tests for spv2/
> >
> > > in LayoutTests/FlagExpectations/enable-slimming-paint-v2:
> > >
> > > crbug.com/657825
> > fast/performance/performance-first-paint-timing-observable.html
> > > [ Skip ]
> > > crbug.com/657825 fast/performance/performance-paint-timing-observable.html
> > [
> > > Skip ]
> > >
> > > Then you can land this CL.
> > >
> > > I will remove the above expectations in
> > > https://codereview.chromium.org/2623043002/.
> >
> >
> >
> > https://codereview.chromium.org/2528513003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Xianzhu, 2017-01-11 22:19:45]

Description was changed from

==========
first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-01-11 22:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 22:52:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunjian, 2017-01-11 22:55:16]

Patchset #18 (id:460001) has been deleted

[sunjian, 2017-01-11 22:56:00]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-11 22:56:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps480001
(title: "added flag to skip first-paint layout tests")

[commit-bot: I haz the power, 2017-01-11 22:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:34:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunjian, 2017-01-12 00:43:06]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-12 00:43:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps500001
(title: "Got rid of DCHECK")

[commit-bot: I haz the power, 2017-01-12 00:44:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2017-01-12 00:47:02]

Patchset #19 (id:500001) has been deleted

[sunjian, 2017-01-12 00:47:23]

The CQ bit was unchecked by sunjian@chromium.org

[sunjian, 2017-01-12 01:09:03]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-12 01:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2528513003/#ps520001
(title: "Got rid of DCHECK cause it breaks unit tests")

[commit-bot: I haz the power, 2017-01-12 01:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2017-01-12 01:34:01]

The CQ bit was unchecked by sunjian@chromium.org

[Xianzhu, 2017-01-12 03:49:03]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:54:29]

CQ is committing da patch.

Bot data: {"patchset_id": 520001, "attempt_start_ts": 1484192943424120,
"parent_rev": "e850e3f2f671adc21ef92570dea76f9146b19e7a", "commit_rev":
"20d9207c7997b8d0d2a978032e25a3a4274a9f5f"}

[commit-bot: I haz the power, 2017-01-12 03:55:04]

Description was changed from

==========
first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
first-paint and first-contentful paint

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2528513003
Cr-Commit-Position: refs/heads/master@{#443142}
Committed:
https://chromium.googlesource.com/chromium/src/+/20d9207c7997b8d0d2a978032e25...
==========

[commit-bot: I haz the power, 2017-01-12 03:55:06]

Committed patchset #19 (id:520001) as
https://chromium.googlesource.com/chromium/src/+/20d9207c7997b8d0d2a978032e25...