third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html - Issue 2528513003: first-paint and first-contentful paint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html

Issue 2528513003: first-paint and first-contentful paint (Closed)

Patch Set: addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/performance/performance-first-paint-timing-observable.html ('k') | third_party/WebKit/Source/core/core_idl_files.gni » ('j') | third_party/WebKit/Source/core/paint/PaintTiming.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <head>

	3 <title>Performance Paint Timing Test</title>

	4 </head>

	5 <body>

	6 <div style="background-color:black;color:white;padding:20px;">...test...</di v>

	7 <script src="../../resources/testharness.js"></script>

	8 <script src="../../resources/testharnessreport.js"></script>

	9 <script>

	10

	11 async_test(function (t) {

	12 var observer = new PerformanceObserver(

	13 t.step_func(function (entryList) {

	14 var entries = entryList.getEntries();

	15 assert_equals(entries.length, 2,
	tdresser 2016/12/08 14:54:40 Does the spec require that these are dispatched at Does the spec require that these are dispatched at the same time? We should write this test such that it should be easy to upstream. panicker 2016/12/09 00:15:01 I would like to spec this so it's dispatched as it Show quoted text On 2016/12/08 14:54:40, tdresser wrote: > Does the spec require that these are dispatched at the same time? We should > write this test such that it should be easy to upstream. I would like to spec this so it's dispatched as it occurs (PerformanceObserver itself doesn't guarantee immediate delivery). That way if there's an abort in between, one could know that the page reached FP atleast.
	16 "There should be two paint timing instances.");

	17 assert_equals(entries[0].entryType, "paint",

	18 "Expected entryType to be: paint.");

	19 assert_equals(entries[0].duration, 0,

	20 "Expected duration to be: 0.");

	21

	22 assert_equals(entries[1].entryType, "paint",

	23 "Expected entryType to be: paint.");

	24 assert_equals(entries[1].duration, 0,

	25 "Expected duration to be: 0.");

	26 observer.disconnect();

	27 t.done();

	28 })

	29 );

	30 observer.observe({entryTypes: ["paint"]});

	31

	32 }, "Both first-paint-timing and first-contentful-paint timing entry are obse rvable.");

	33

	34 </script>

	35 </body>

	36 </html>

OLD	NEW