third_party/WebKit/Source/core/timing/PerformanceEntry.cpp - Issue 2528513003: first-paint and first-contentful paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

Issue 2528513003: first-paint and first-contentful paint (Closed)

Patch Set: Got rid of DCHECK cause it breaks unit tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

diff --git a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

index 46791f12dcedc73ab922af952666259fc78f9b4e..a67298e6158244bb23a65e9fd373a4889b71fe58 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

+++ b/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp

@@ -81,6 +81,8 @@ PerformanceEntry::EntryType PerformanceEntry::toEntryTypeEnum(

return Navigation;

if (entryType == "taskattribution")

return TaskAttribution;

+ if (entryType == "paint")

+ return Paint;

return Invalid;

}