third_party/WebKit/Source/core/paint/PaintTiming.h - Issue 2528513003: first-paint and first-contentful paint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintTiming.h

Issue 2528513003: first-paint and first-contentful paint (Closed)

Patch Set: addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/performance/performance-paint-timing-observable.html ('K') | « third_party/WebKit/Source/core/core_idl_files.gni ('k') | third_party/WebKit/Source/core/paint/PaintTiming.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintTiming.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PaintTiming_h	5 #ifndef PaintTiming_h

6 #define PaintTiming_h	6 #define PaintTiming_h

7	7

8 #include "core/dom/Document.h"	8 #include "core/dom/Document.h"

9 #include "core/paint/FirstMeaningfulPaintDetector.h"	9 #include "core/paint/FirstMeaningfulPaintDetector.h"

	10 #include "core/timing/PerformancePaintTiming.h"
	tdresser 2016/12/08 14:54:40 Is this needed? Is this needed? panicker 2016/12/09 00:15:01 Revert this file? The idea was to remove this dep. Show quoted text On 2016/12/08 14:54:40, tdresser wrote: > Is this needed? Revert this file? The idea was to remove this dep. sunjian 2016/12/09 19:06:49 Done. Show quoted text On 2016/12/08 14:54:40, tdresser wrote: > Is this needed? Done.
10 #include "platform/Supplementable.h"	11 #include "platform/Supplementable.h"

11 #include "platform/heap/Handle.h"	12 #include "platform/heap/Handle.h"

12 #include "wtf/Noncopyable.h"	13 #include "wtf/Noncopyable.h"

13	14

14 namespace blink {	15 namespace blink {

15	16

16 class LocalFrame;	17 class LocalFrame;

17	18

18 // PaintTiming is responsible for tracking paint-related timings for a given	19 // PaintTiming is responsible for tracking paint-related timings for a given

19 // document.	20 // document.

(...skipping 89 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 double m_firstMeaningfulPaint = 0.0;	110 double m_firstMeaningfulPaint = 0.0;

110 double m_firstMeaningfulPaintCandidate = 0.0;	111 double m_firstMeaningfulPaintCandidate = 0.0;

111	112

112 Member<Document> m_document;	113 Member<Document> m_document;

113 Member<FirstMeaningfulPaintDetector> m_fmpDetector;	114 Member<FirstMeaningfulPaintDetector> m_fmpDetector;

114 };	115 };

115	116

116 } // namespace blink	117 } // namespace blink

117	118

118 #endif	119 #endif

OLD	NEW